Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Python 3.7 from tests actions #219

Closed
luabud opened this issue Sep 22, 2023 · 4 comments · Fixed by #220
Closed

Remove Python 3.7 from tests actions #219

luabud opened this issue Sep 22, 2023 · 4 comments · Fixed by #220
Assignees
@Riya28
Labels
debt good first issue needs PR

Comments

@luabud
Copy link
Member

luabud commented Sep 22, 2023

Given we are dropping Python 3.7 support, we could remove Python 3.7 from our tests actions: https://github.com/microsoft/vscode-flake8/blob/main/.github/workflows/pr-check.yml
@Riya28
Copy link
Contributor

Riya28 commented Sep 22, 2023

Hi can I be assigned this issue?

@eleanorjboyd eleanorjboyd mentioned this issue Sep 22, 2023
Merged
@pipinfitriadi
Copy link

pipinfitriadi commented Oct 19, 2023 •
edited

Why python 3.7 no longer support @luabud?

@karthiknadig
Copy link
Member

karthiknadig commented Oct 19, 2023 •
edited

Latest version of flake8 dropped support for 3.7
See here: https://pypi.org/project/flake8/6.1.0/#data
Minimum supported is 3.8.1

pipinfitriadi referenced this issue in PyCQA/flake8 Oct 19, 2023
@asottile
require python 3.8.1+
aa002ee
@pipinfitriadi
Copy link

pipinfitriadi commented Oct 19, 2023 •
edited

Latest version of flake8 dropped support for 3.7 See here: https://pypi.org/project/flake8/6.1.0/#data Minimum supported is 3.8.1

@karthiknadig ok thanks.. I'll try to reach flake8 author
PyCQA/flake8@aa002ee?diff=unified#r130371862

@pipinfitriadi pipinfitriadi mentioned this issue Oct 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Riya28 Riya28

Labels
debt good first issue needs PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed python 3.7 from tests action Riya28/vscode-flake8
4 participants
@karthiknadig @Riya28 @pipinfitriadi @luabud