Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node_modules to .vscodeignore when using webpack #258

Closed
felipecrs opened this issue Mar 29, 2021 · 1 comment
Closed

Add node_modules to .vscodeignore when using webpack #258

felipecrs opened this issue Mar 29, 2021 · 1 comment
Assignees
Milestone

Comments

@felipecrs
Copy link
Contributor

I'm not expert, but I think one of the points of webpack is to prevent node_modules from being included in the extension. Right?

@aeschli
Copy link
Contributor

aeschli commented May 3, 2021

Yes, you are right. You can still have node modules if you define externals in the webpack file. So in that case hand tuning is needed.

@aeschli aeschli added this to the April 2021 milestone May 3, 2021
@aeschli aeschli self-assigned this May 3, 2021
@aeschli aeschli closed this as completed in 82bf595 May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants