Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for webpacked generator are not valid #299

Closed
felipecrs opened this issue Sep 7, 2021 · 4 comments
Closed

Tests for webpacked generator are not valid #299

felipecrs opened this issue Sep 7, 2021 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@felipecrs
Copy link
Contributor

felipecrs commented Sep 7, 2021

  1. The tests included in the webpacked generator does not really test if the extension gets activated
  2. It succeeds currently, because the extension does not get activated at all
  3. If we try to activate the extension (which everyone will do for running their own tests), it fails, because no ./dist/extension.js can be found (as in such case, the file is at ./out/extension.js).
@felipecrs
Copy link
Contributor Author

snowpack and its handy test mode is a good option, as long as FredKSchott/snowpack#3718 gets fixed.

@aeschli
Copy link
Contributor

aeschli commented Sep 22, 2021

Thanks! There's a missing npm run compile in pretest.

Fixed by c48bd68

@aeschli aeschli self-assigned this Sep 24, 2021
@aeschli aeschli added the bug Issue identified by VS Code Team member as probable bug label Sep 24, 2021
@aeschli aeschli added this to the September 2021 milestone Sep 24, 2021
@aeschli
Copy link
Contributor

aeschli commented Sep 24, 2021

Thanks, I pushed another changeset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants