Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsconfig.json confusing settings #323

Closed
memeplex opened this issue Dec 18, 2021 · 1 comment
Closed

tsconfig.json confusing settings #323

memeplex opened this issue Dec 18, 2021 · 1 comment
Assignees
Milestone

Comments

@memeplex
Copy link

The compilar configuration includes both:

	"exclude": [
		"node_modules",
		".vscode-test"
	]

and

	"compilerOptions": {
		"rootDir": "src",

According to the documentation exclude:

Specifies an array of filenames or patterns that should be skipped when resolving include. Important: exclude only changes which files are included as a result of the include setting.

And regarding rootDir:

Note that TypeScript will never write an output file to a directory outside of outDir, and will never skip emitting a file. For this reason, rootDir also enforces that all files which need to be emitted are underneath the rootDir path.

So it seems that the exclude setting may be both ineffective (because there is no include) and redundant (because rootDir is already enforcing that all emitted files are underneath src).

@aeschli
Copy link
Contributor

aeschli commented Jan 12, 2022

I think you are correct, you can delete the exclude section.

@aeschli aeschli self-assigned this Jan 12, 2022
@aeschli aeschli added this to the January 2022 milestone Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants