Test Plan for May 2018 update (0.6.81)

[ramya-rao-a]

If you got a notification from this issue, then you are part of the next update to the Go extension.
Thanks and Welcome!

As most of you know already, I am the sole maintainer of this project at the moment. I wanted to try something different for this next update.

Here I will be listing the features and the bug fixes that will go in the next update along with the the folks who logged the bugs/feature requests, those who upvoted it, and those who fixed it by sending PRs.

The idea is to get the folks behind this update to give the update a trial run before I release it.
I always do basic testing before every update. But because I dont work with Go in my day job, I always feel that someone who does Go more than me can help in testing tremendously.

And when I say "test", you can do a minimum pass of just installing the update and then do nothing special other than going about using VS Code like you do everyday. Or you can test the feature you requested/implemented or the bug you logged/fixed. Or you can test all of the below. Every bit helps.

Drop in a comment in this issue after 2 or 3 days of installing the update with your findings.
Also, let me know in the comments what you think of this model of me asking your help in testing an update before releasing it.

Feature Requests:

• Autocompletion in declaration comment should suggest nearest declaration before others #1005 Include stub with exported member name on the comment above it in completions. Use Ctrl+Space to trigger completions inside comments. cc @shreyu86, @atombender, @shurcooL, @ruedap
• use completion feature comes from go-langserver #1593 Use code-completion feature from language server. Ensure to use both go.useLanguageServer and go.languageServerExperimentalFeatures to test this. cc @m90, @leaxoy, @OneOfOne, @primalmotion, @Contextualist
• Migrate delve calls to v2 API #1555 Use version 2 apis of delve that enables watching strings and arrays whose size is > 64. First set useApiV1 to false in the debug config to test this. Then configure dlvLoadConfig in the same place to control the array size to display. cc @lggomez, @sirikon, @michaelmello, @jgfet, @Arman92, @carusyte
• Add support for golangci-lint as the lintTool #1693 Support to use golangci-lint as a linter. cc @golangci, @atombender, @caarlos0, @lafin, @nikitabokovoy
• Add revive linter #1697 Support to use revive as a linter. cc @Southclaws, @mgechev, @wolfeidau
• Test coverage highlight colors are not colorblind friendly #1302 Make the test coverage colors/styles more colorblind friendly. cc @kentquirk, @dcormier, @sigwinch28, @Mistobaan

Bugs:

• formatting doesn't work 90% of the time when language server is enabled #1667 Issue with formatting when using the language server. cc @OneOfOne
• Go development is generally slow when using github.com/uudashr/gopkgs #1490 Perf issue with using gopkgs. cc @codingconcepts, @uudashr
• Coverage display is misinterpreting the coverprofile file #1683 Fix code coverage when code is covered by multiple tests. cc @kentquirk

[ramya-rao-a]

To install the update,

• Download https://github.com/Microsoft/vscode-go/blob/master/Go-latest.vsix
• Run code --install-extension Go-latest.vsix
• If the above fails with Error: end of central directory record signature not found, then clone this repo and use the Go-latest.vsix file from the cloned repo
• Reload VS Code

[primalmotion]

Hi,

I tried to use golangci-lint seems to work, but when I save, the cursor goes straight to the end of the file.

[caarlos0]

Hi,

tried golangci-lint, seems to work ok for me. Didn't had this problems related to going to end of the file as @primalmotion reported (or at least I didn't notice them)

[primalmotion]

Actually it is not golangci-lint, but it is when I enable the formatting by language-server

[ramya-rao-a]

@primalmotion The formatter from the language server is not yet stable. Did you enable it explicitly using the go.languageServerExperimentalFeatures setting?

[primalmotion]

yeah I did. let me disable it. Is autoComplete from go.languageServerExperimentalFeatures more or less stable?

[ramya-rao-a]

autoComplete is stable. It doesn't have features like automatic importing of unimported packages when completing symbols from the unimported packages though. That's why I wanted to add an option for users to use the default auto-completion feature.

If all is well with it after this testing, I can change the default value for autocomplete in go.languageServerExperimentalFeatures to true

[primalmotion]

Oh I see. No autoimport is game over for me :) I’ll wait before activating it.

Other than that (and the debugger that never really worked for me), everything seems to work well

[OneOfOne]

It seems to work fine for me but I don't think we should set it as the default just yet, maybe in 1-2 more releases or at least until after automatic imports works.

[leaxoy]

AutoComplete feature come from go-langserver works for me, this looks great, thanks for your work.

[wolfeidau]

@ramya-rao-a Tested out revive and made a PR just for some README updates #1703

Integration worked great once it was correctly configured.

[ramya-rao-a]

Thanks @wolfeidau! Do try out the -config flag with file paths having ~ for homer or the ${workspaceRoot} variable

[Southclaws]

Revive is working great! Tested on osx and windows. ~ and ${workspaceRoot} work fine on both platforms.

[m90]

I've used the "pre-release" version for the last 1 1/2 days and it seems to work mostly fine.

The only feature that is giving me issues is the go-langserver based formatting, which sometimes creates the "jump-to-bottom" behavior described by @primalmotion as well as gives me a slightly annoying flashing on save (syntax highlighting is removed, all code is displayed in white, syntax highlighting is reapplied):

From having a quick glance at the code it looks to me as if these are upstream issues though, either in the language server or the language server interface of VSCode, so I doubt this is to be fixed here.

I'll probably not turn on the language server formatting, but other than that, the update is more than welcome. Thanks to everyone involved.

---

Also, let me know in the comments what you think of this model of me asking your help in testing an update before releasing it.

I think this is a really great format for cutting releases. The thread above also looks like it's working, so 👍

[Southclaws]

^I've noticed the syntax flashing on a few other file types too, it definitely seems like a general issue rather than Go-specific.

[kentquirk]

The change to go-cover works fine for me. And I've just tested the visual settings (thanks for integrating those!). They seem to be working fine.

I think it's a fine idea to ask for help testing.

[shreyaskarnik]

I have been using the extension for the past day without any issues and have tested the following:

• golangci-lint
• completion in comments for exported variables

[ramya-rao-a]

Great, thanks everyone!
I'll release the update first thing on Monday morning.

[ramya-rao-a]

Thanks to each and everyone here, the update has been released!