feat: Support basic java plugin aware #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CsCherrYY
force-pushed
the
cs-issue982-plugin
branch
from
49f7ab6
to
fb77695
Compare
CsCherrYY
commented
Sep 7, 2021
| private String gradleHome; | ||
| private String gradleVersion; | ||
| private boolean gradleWrapperEnabled; | ||
| private String gradleUserHome; | ||
| private Path workspacePath; | ||
|
|
||
| public GradleLibraryResolver() { | ||
| this.javaPlugins.addAll(Arrays.asList("java", "application", "groovy", "java-library", "war")); |
There was a problem hiding this comment.
The rest four plugins apply java plugin as well.
CsCherrYY
force-pushed
the
cs-issue982-plugin
branch
from
fb77695
to
183be78
Compare
CsCherrYY
commented
Sep 23, 2021
| return; | ||
| } | ||
| for (Field field : javaPluginClass.getFields()) { | ||
| if (field.getName().endsWith("CONFIGURATION_NAME")) { |
There was a problem hiding this comment.
CsCherrYY
force-pushed
the
cs-authoring-branch
branch
from
618cc7a
to
082e3d7
Compare
CsCherrYY
force-pushed
the
cs-issue982-plugin
branch
from
183be78
to
f6cde24
Compare
testforstephen
approved these changes
Sep 23, 2021
CsCherrYY
added a commit
that referenced
this pull request
Sep 24, 2021
CsCherrYY
added a commit
that referenced
this pull request
Sep 26, 2021
* feat: Initialize Language Server (#959) * feat: Support compiling and pushing diagnostics (#962) * feat: Support basic groovy syntax highlighting (#960) * feat: Support semantic highlighting (#967) * feat: Support document outline (#969) * feat: Support auto completion in dependencies closure (#970) * feat: Support Basic Auto Completion (#971) * fix: Add null check for visitors (#974) * feat: Show symbol detail for method calls (#973) * chore: Prepare for 3.8.0 (#978) * fix: Use padding to correct version order (#986) * fix: Dependency completion doesn't work when multiple dependencies closures exist (#984) * fix: Correct version completion kind (#985) * fix: Handle multiple content changes (#992) * feat: Support completion for settings.gradle (#988) * fix: Offer completion results from supertypes (#987) * feat: Provide dependencies content in outline (#998) * feat: Support basic java plugin aware (#989) * feat: Support basic tasks and dependencies (#1002) * chore: Add thirdpartynotice * chore: Fix ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #982
In
CompletionVisitor, supports two kinds of plugin declaration:and
and collect the applied plugins information.
In
GradleLibraryResolver, get available java related configurations from public fields inorg.gradle.api.plugins.JavaPluginIn
CompletionHandler, if current closure isdependenciesand java related plugin is applied, we offer java configurations as completion items too.