-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search returned an error! #149
Comments
Using a non-matching regex |
I would like to take this on. |
@WalterLPearson nobody has taken a look at this yet, it would be great if you did! I think the issue here is search runs on the same thread as the ext host meaning we constantly interrupt its location on the event loop. The best solution here is to probably place search in a separate worker |
Should I use standard Node worker_thread, or does vscode have a special worker class to use? |
No special workers for VS code. You will have to have a worker implementation for web and node separately most likely as the hex editor must work in the browser too |
Strangest thing, vscode crashes when trying to reproduce error in debugger. I cannot progress without working debugger. |
Search has been re-implemented this should no longer be the case please let me know if you run into any issues still |
Testing microsoft/vscode#103176
Renderer:
Webview:
The text was updated successfully, but these errors were encountered: