Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search returned an error! #149

Closed
Tyriar opened this issue Jul 24, 2020 · 7 comments
Closed

Search returned an error! #149

Tyriar opened this issue Jul 24, 2020 · 7 comments
Labels
bug Issue identified by VS Code Team member as probable bug find / replace widget Issues relating to the find and replace wdiget

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 24, 2020

Testing microsoft/vscode#103176

image
Renderer:
image
Webview:

image

@lramos15 lramos15 added bug Issue identified by VS Code Team member as probable bug find / replace widget Issues relating to the find and replace wdiget labels Jul 24, 2020
@chrmarti
Copy link

Using a non-matching regex .* .* .* .* .* .* .* .* .* foobar also shows the same error. The webview console shows a timeout, so the error message could be more specific in this case.

@WalterLPearson
Copy link

I would like to take this on.
Has anyone looked into this more?

@lramos15
Copy link
Member

@WalterLPearson nobody has taken a look at this yet, it would be great if you did! I think the issue here is search runs on the same thread as the ext host meaning we constantly interrupt its location on the event loop. The best solution here is to probably place search in a separate worker

@WalterLPearson
Copy link

Should I use standard Node worker_thread, or does vscode have a special worker class to use?

@lramos15
Copy link
Member

No special workers for VS code. You will have to have a worker implementation for web and node separately most likely as the hex editor must work in the browser too

@WalterLPearson
Copy link

WalterLPearson commented Oct 25, 2021

Strangest thing, vscode crashes when trying to reproduce error in debugger.
Using clean install of vscode with all Extension development and hexeditor instructions followed exactly.
Client window crashes and execution terminates with:
"The window has crashed (reason:'crashed', code:'-2147483645')"

I cannot progress without working debugger.

@lramos15
Copy link
Member

Search has been re-implemented this should no longer be the case please let me know if you run into any issues still

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug find / replace widget Issues relating to the find and replace wdiget
Projects
None yet
Development

No branches or pull requests

4 participants