Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Doesn't work #61

Open
Gilwyad opened this issue Jun 17, 2019 · 7 comments
Open

Doesn't work #61

Gilwyad opened this issue Jun 17, 2019 · 7 comments

Comments

@Gilwyad
Copy link

Gilwyad commented Jun 17, 2019

Installed 0.6.0 on VS Code 1.35 and it does nothing, invalid HTML files are not highlighted.
@kanlukasz
Copy link

Can you share a file with us that is not highlighted?
Have you tried version 1.40?
Have you tried with other extensions turned off?

@Gilwyad
Copy link
Author

Gilwyad commented Nov 26, 2019

Here's one:

<html>
<body>
    <ol>
        <li>

    </ol>
    </li>
</body>
</html>

Nothing is highlighted in VS Code. Tried with no htmlhint cli installed, with 0.11.0 installed globally, on VS Code 1.40.1 , all other extensions disabled.

@kanlukasz
Copy link

I tried that right now with 1.40.2 - everything works fine, look at my screenshot:

obraz

Have you saved the file? Please note that the plugin cannot work (from what I see) if the file does not exist physically on your disk

_

@Gilwyad
Copy link
Author

Gilwyad commented Nov 28, 2019

I tried it on a Windows machine and indeed it works. However I am using Ubuntu 18 and that's where it doesn't work. How can I debug this? There should be a way that I can see the extensions error messages.

@kanlukasz
Copy link

I am sorry to hear it. I'm not the author of the plugin, so I don't know how to help you more. What's worse, from what I see, the author has not been fixing problems for some time :(

@Gilwyad
Copy link
Author

Gilwyad commented Nov 28, 2019 •
edited

I was able to track down the problem: if I have this configuration set:

"htmlhint.options": {
    "attr-lowercase": false
},

then the extension doesn't work. But if I remove it (and restart) then it does work!

And I was testing with lower case tags, e.g. <h5></h4> so it should show the error regardless of case.

@tahaerden
Copy link

I was able to track down the problem: if I have this configuration set:

"htmlhint.options": {
    "attr-lowercase": false
},

then the extension doesn't work. But if I remove it (and restart) then it does work!

And I was testing with lower case tags, e.g. <h5></h4> so it should show the error regardless of case.

Yes I just installed the extension and noticed the htmlhint.options override all options and not only the ones inside this object.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Gilwyad @tahaerden @kanlukasz