Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todo project: skip testEqualsObjects method #488

Closed
bsaby opened this issue Dec 3, 2018 · 2 comments
Closed

Todo project: skip testEqualsObjects method #488

bsaby opened this issue Dec 3, 2018 · 2 comments
Assignees
Labels
Milestone

Comments

@bsaby
Copy link

bsaby commented Dec 3, 2018

Build: 359
Project: https://github.com/Microsoft/todo-app-java-on-azure

Run from workspace root/workspace folder, the testEqualsObject method will be skipped.
image
Test output:
image

@bsaby bsaby mentioned this issue Dec 10, 2018
8 tasks
@jdneo
Copy link
Member

jdneo commented Dec 20, 2018

Root cause

The code logic here is wrong:

public static List<JUnit4TestReference> createTestReferences(String[] suites) {
    if (suites.length == 0) {
        return emptyList();
    } else if (suites.length == 1) {
        final String suite = suites[0];
        final int separatorIndex = suite.indexOf('#');
        return separatorIndex == -1 ? getRequestForClass(suite) : getRequestForOneMethod(suite, separatorIndex);
    }
    return getRequestForClasses(suites);
}

We should determine the suite is a method or class by its full name, not the array length.

@jdneo
Copy link
Member

jdneo commented Dec 20, 2018

@bsaby Fixed.

@bsaby bsaby self-assigned this Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants