Support .jshintignore files

[kieferrm]

We should respect .jshintignore files as described in http://jshint.com/docs/cli/

[kieferrm]

Started development in https://github.com/Microsoft/vscode-jshint/tree/feature/jshintignore.

[kieferrm]

Closed with 49b9258.

[baelter]

Can't get this to work,

Putting

**/*

in .jshintignore and all files are linted.

vscode: 1.21.1
vscode-jshint: 0.10.17
jshint: 2.9.5

[osya]

@baelter , confirm that .jshintignore support in vscode-jshint is not worked as expected.

Projects structure:

• app - src - index.jsx

Step to reproduce

1. Add to user settings

"jshint.exclude": {
    "**/*.jsx": true
},

index.jsx for jshint ignored. It is as expected
2. Add an empty file .jshintignore to the project root and restart VS Code
index.jsx for jshint is NOT igored. It is a bug
3. Add src/** in the .jshintignore file and restart VS Code
index.jsx is ignored in PyCharm - so .jshintignore is correct. In VS Code index.jsx for jshint is NOT igored. It is a bug
4. Remove jshint.exclude from user settings and restart VS Code
index.jsx for jshint is NOT igored. It is a bug

vscode: 1.23.1
vscode-jshint: 0.10.18
jshint: 2.9.5

[RMacfarlane]

@baelter @osya Thanks for reporting and the clear steps to reproduce! There was an issue with caching that I just checked in a fix for. The extension maintains a cache for excludes that was correctly being cleared when the ignore file updated, but there was also a cache being maintained by a parsing library that didn't ever get reset. I'll publish a new version of the extension soon.

[RMacfarlane]

@baelter @osya Just published a new version of the extension. Please give it a try

[osya]

@RMacfarlane , thank you for your attention. I just checked. But the issue still exists.

vscode: 1.24.0
vscode-jshint: 0.10.19
jshint: 2.9.5

[RMacfarlane]

@osya Hmm, I've tried your steps above with the versions you listed and it works for me. Could you share your settings?

[osya]

@RMacfarlane , sorry. It works. I just added the content **/*.jsx to the file .jshintignore and then jshint begins ignoring *.jsx files. Empty file .jshintignore with the user setting

"jshint.exclude": {
    "**/*.jsx": true
},

does not ignore *.jsx files. It seems it is correct