Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel Picker - Native Notebooks #1206

Closed
claudiaregio opened this issue Aug 17, 2020 · 7 comments
Closed

Kernel Picker - Native Notebooks #1206

claudiaregio opened this issue Aug 17, 2020 · 7 comments
Assignees

Comments

@claudiaregio
Copy link
Contributor

Kernel Picker Artifact:

Design/Location:

  • Kernel picker to be moved to status bar in bottom left.
  • Python Interpreter to be hidden for notebooks.
  • Kernel picker and connection string to the right of it.

Experience:

  • Kernel picker will be generated in status bar per notebook.

  • Local: (local white connected icon)

  • Remote:

  1. If custom display string available, display (remote: custom string white connected icon)
    https://github.com/microsoft/vscode-python/issues/12988
  2. If no custom display available, display (remote white connected icon)
  3. When hovering over the remote string, hover tip to display full url.
  • Clicking the kernel picker will result in quick pick menu options.
  • When new option selected, kernel picker to update.

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer, @joyceerhl

@SiddhanthUnnithan
Copy link

It would be ideal if users can click on the "Jupyter server: ..." label in the new UI to invoke the "Python: Specify local or remote Jupyter server for connections" command.

@DonJayamanne
Copy link
Contributor

the new UI to invoke the "Python: Specify local or remote Jupyter server for connections" command.

However, we should not have to reload VS Code. Else it seems broken.
I.e. if you click on an icon in the UI and then are expected to re-load VSC, then it should be a command (command can be non-editor specific)
Or we should fix the code that requires users to reload VSCode.

@SiddhanthUnnithan
Copy link

the new UI to invoke the "Python: Specify local or remote Jupyter server for connections" command.

However, we should not have to reload VS Code. Else it seems broken.
I.e. if you click on an icon in the UI and then are expected to re-load VSC, then it should be a command (command can be non-editor specific)
Or we should fix the code that requires users to reload VSCode.

Agreed - I was under the impression that this was a problem because of the lack of custom editor support but that it would be fixed with the Native Notebooks work. I haven't tested it yet myself.

@greazer
Copy link
Contributor

greazer commented Aug 18, 2020

No custom editing support needs to reload for completely different reasons.
This is something we need to change in our extension, I believe.

@DonJayamanne
Copy link
Contributor

No custom editing support needs to reload for completely different reasons.

Not sure what you mean by this.

@SiddhanthUnnithan
Copy link

@DonJayamanne is there any further clarification you needed from me re: this issue?

@greazer greazer assigned claudiaregio and unassigned claudiaregio Aug 20, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 13, 2020
@DonJayamanne
Copy link
Contributor

Duplicate of #254

@DonJayamanne DonJayamanne marked this as a duplicate of #254 Jan 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants