Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If on 'http://localhost', the notebookFileRoot should still be used #1551

Closed
rchiodo opened this issue Dec 18, 2019 · 1 comment · Fixed by #8527
Closed

If on 'http://localhost', the notebookFileRoot should still be used #1551

rchiodo opened this issue Dec 18, 2019 · 1 comment · Fixed by #8527
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues good first issue Good for newcomers

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Dec 18, 2019

Specify a remote server URI that's local
Open a notebook that would be local to that host
Run this code:

import os
os.getcwd()

Expected result:
Root of notebook

Actual result:
Workspace root.

This is because we skip changing the directory of the kernel when the server URI is set. We could instead set this whenever the server URI is local.

@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 13, 2020
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug temp-parking and removed temp-parking labels Nov 13, 2020
@DonJayamanne DonJayamanne added the debt Code quality issues label Sep 1, 2021
@rchiodo rchiodo self-assigned this Dec 10, 2021
@rchiodo
Copy link
Contributor Author

rchiodo commented Dec 10, 2021

Going to try and make localhost behave like running locally if possible.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants