Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to save SVG in Jupyter Cells Output #5827

Closed
shriaviator opened this issue May 11, 2021 · 2 comments
Closed

Unable to save SVG in Jupyter Cells Output #5827

shriaviator opened this issue May 11, 2021 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@shriaviator
Copy link

shriaviator commented May 11, 2021

Environment data

  • VS Code version: 1.56.0
  • Jupyter Extension version (available under the Extensions sidebar): v2021.6.811652604
  • Python Extension version (available under the Extensions sidebar): v2021.5.829140558
  • OS (Windows | Mac | Linux distro) and version: Pop_Os 20.04 LTS
  • Python and/or Anaconda version: 3.8.8
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda
  • Jupyter server running: Local | Remote | local

Expected behaviour

  • Click save to SVG : File saves to svg

Actual behaviour

Nothing Happens

Steps to reproduce:

[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]

import altair as alt
import pandas as pd

source = pd.DataFrame({
    'a': ['A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I'],
    'b': [28, 55, 43, 91, 81, 53, 19, 87, 52]
})

alt.Chart(source).mark_bar().encode(
    x='a',
    y='b'
)
  • Vscode / jupyter : Save as PNG works as expected and saves output
  • Jupyter-Lab : save as svg works as expected

jupyter

Logs

Output for Jupyter in the Output panel (ViewOutput, change the drop-down the upper-right of the Output panel to Jupyter)

Nil Logs 

@shriaviator shriaviator added the bug Issue identified by VS Code Team member as probable bug label May 11, 2021
@shriaviator shriaviator changed the title Unable to save Unable to save SVG in Jupyter Cells Output May 11, 2021
@IanMatthewHuff
Copy link
Member

@shriaviator Thanks for the report here, I tested it out, and I see the same issue as you do.

Just to note here. In vscode-insiders we are rolling out a new UI based on VS Code's new Native Notebook support. I just went and checked in it and this scenario does work there and I can save a SVG.

image

We may be unlikely to fix this in the old UI as this new UI will be replacing it in upcoming releases.

@IanMatthewHuff IanMatthewHuff self-assigned this May 11, 2021
@greazer
Copy link
Contributor

greazer commented May 13, 2021

Thanks for your feedback. This issue will be addressed once VS Code adds native support for editing notebooks. Please see microsoft/vscode#91987. You can experiment by using VS Code insiders, which defaults to the new notebook experience.

@greazer greazer closed this as completed May 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

3 participants