Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask VS code for disabling language picker #6211

Closed
Tracked by #5607
rchiodo opened this issue Jun 8, 2021 · 5 comments
Closed
Tracked by #5607

Ask VS code for disabling language picker #6211

rchiodo opened this issue Jun 8, 2021 · 5 comments

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Jun 8, 2021

This isn't supported at the moment. Need VS code changes.

Time estimate is how long it would take to add it to VS code. Basically change their 'when' clause for select language.

@greazer greazer added this to the July 2021 Release milestone Jun 8, 2021
@claudiaregio
Copy link
Contributor

Is this to have a setting to hide the language picker along the right side of the notebook?

@rchiodo
Copy link
Contributor Author

rchiodo commented Jun 10, 2021

Is this to have a setting to hide the language picker along the right side of the notebook?

Yeah. Part of the spec for Run by Line asked for the ability to prevent changing the language while debugging.

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Jun 10, 2021

So this isn't a must fix. It's a nice to have (if at all)
I mean why would a user change the cell language, won't we have the same problem with users changing language of the python file (when debugging interactive window), that too is possible today, but we don't try to disable that!

Ie, why are we trying to do this. Is it fear that users can do this which could screw debugging experience?

I don't think this is a good ask.

@claudiaregio
Copy link
Contributor

If it helps get RBL in faster, we can table this

@DavidKutu
Copy link

Do we want this for other stuff besides run by line?

I was talking with Rob and we concluded that there's no point in doing this. We followed Don's example.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants