Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native interactive window - interrupt doesn't seem to work (at least on Windows) #6513

Closed
rchiodo opened this issue Jul 2, 2021 · 5 comments
Assignees
Labels
interactive-window Impacts interactive window

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Jul 2, 2021

Run this code:

import time
while (True):
    time.sleep(.1)
    print('*')

Hit the interrupt button. No interrupt.

Same code in a native notebook works (and throws the expected KeyboardException)

@rchiodo rchiodo added the bug Issue identified by VS Code Team member as probable bug label Jul 2, 2021
@joyceerhl
Copy link
Contributor

joyceerhl commented Jul 2, 2021

Strange, interrupt seems to work for me on Windows

image

Do you have the logs?

@rchiodo
Copy link
Contributor Author

rchiodo commented Jul 2, 2021

no_interrupt.log

@rchiodo
Copy link
Contributor Author

rchiodo commented Jul 2, 2021

I had to do a restart at the end to get it to actually stop spewing output, so that's why there's a restart in there

@greazer greazer added the interactive-window Impacts interactive window label Jul 8, 2021
@greazer
Copy link
Contributor

greazer commented Jul 8, 2021

Please add more logging so we can figure out what's happening.

@greazer
Copy link
Contributor

greazer commented Jul 8, 2021

After discussion, we determined this is more a problem with handling interrupt on Windows. If you change the delay to 1 sec vs .1 and it works, then this is the problem and there's not much we can do.

@greazer greazer closed this as completed Jul 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2021
@DonJayamanne DonJayamanne added duplicate and removed bug Issue identified by VS Code Team member as probable bug labels Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
interactive-window Impacts interactive window
Projects
None yet
Development

No branches or pull requests

4 participants