Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run line by line stop button is different from cell stop #6860

Closed
Tracked by #5607
miguelsolorio opened this issue Jul 27, 2021 · 1 comment
Closed
Tracked by #5607

Run line by line stop button is different from cell stop #6860

miguelsolorio opened this issue Jul 27, 2021 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-run-by-line verified Verification succeeded
Milestone

Comments

@miguelsolorio
Copy link

Testing microsoft/vscode#129467

The one on the left of the cell is using codicon-notebook-stop and the one in the toolbar is codicon-debug-stop. I'd say we use the same codicon-notebook-stop icon.

CleanShot 2021-07-27 at 12 57 47@2x

@miguelsolorio
Copy link
Author

Regarding this note:

There are two stop buttons visible (the normal cancel button and the RBL stop button in the cell toolbar) but these will be merged

If run line by line goes into the consolidated run buttons, then it makes sense to not show anything in the cell toolbar. If it's visible in the cell toolbar only, then i think hiding the one to the left makes sense. I still think we should only use the codicon-notebook-stop icon

@roblourens roblourens transferred this issue from microsoft/vscode Jul 27, 2021
@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Jul 27, 2021
@roblourens roblourens removed their assignment Jul 27, 2021
@DavidKutu DavidKutu added this to the August 2021 milestone Aug 3, 2021
@DavidKutu DavidKutu mentioned this issue Aug 14, 2021
9 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2021
@lramos15 lramos15 added the verified Verification succeeded label Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-run-by-line verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants