Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native VS Code api instead of old Loggers to detect cell execution #7037

Closed
Tracked by #5607
DonJayamanne opened this issue Aug 9, 2021 · 0 comments
Closed
Tracked by #5607
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues notebook-run-by-line verified Verification succeeded
Milestone

Comments

@DonJayamanne
Copy link
Contributor

Today we have nativePostExecute
We added this specifically for the new Debugger coee.
I think this should be removed & we should just use native VS Code API to detect whena cell has been executed.

export class DebuggingCellMap implements IDebuggingCellMap, INotebookExecutionLogger {

This class introduced a new event into a logger that basically wraps existing VSCode API.

@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Aug 9, 2021
@rchiodo rchiodo added debt Code quality issues and removed needs-triage labels Aug 12, 2021
@rchiodo rchiodo modified the milestone: August 2021 Aug 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
@DavidKutu DavidKutu added this to the August 2021 milestone Aug 27, 2021
@roblourens roblourens added the verified Verification succeeded label Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues notebook-run-by-line verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants