Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide breakpoints when in a RBL session #7563

Closed
Tracked by #5607
DonJayamanne opened this issue Sep 16, 2021 · 5 comments
Closed
Tracked by #5607

Hide breakpoints when in a RBL session #7563

DonJayamanne opened this issue Sep 16, 2021 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-debugging notebook-run-by-line

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Sep 16, 2021

  • Use run by line
  • Add 2 break points
  • Hit the Continue button, and it will run to completion without stopping at the break points

Identified when @DavidKutu was demoing the Continue feature.

@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Sep 16, 2021
@DavidKutu
Copy link

This is intended, the button is meant to exit RBL mode and execute the cell normally.

@greazer
Copy link
Contributor

greazer commented Sep 16, 2021

We need to finalize the UI coordination between RBL and notebook debugging.

@DavidKutu DavidKutu changed the title Continue does not work when there's a break point Hide breakpoints when in a RBL session Sep 16, 2021
@DavidKutu
Copy link

We decided on hiding the breakpoints while using RBL. Not removing them, as they need to persist. Just hide them.

@DavidKutu DavidKutu added this to the October 2021 milestone Sep 16, 2021
@greazer greazer modified the milestones: October 2021, On Deck Oct 7, 2021
@roblourens
Copy link
Member

roblourens commented Oct 9, 2021

We could switch them to look like this, which is what unbound breakpoints look like

image

I suspect that they are actually being bound but then manually skipped over by RBL

@roblourens
Copy link
Member

I think this is ok, haven't heard about confused users

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-debugging notebook-run-by-line
Projects
None yet
Development

No branches or pull requests

5 participants