Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust error notification behavior when unable to connect to the remote jupyter server #9167

Closed
DonJayamanne opened this issue Mar 1, 2022 · 3 comments · Fixed by #9941
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Mar 1, 2022

  • Connect to remote Jupyter server A
  • Kill the jupyter server
  • Reload VS Code
  • Open a notebook and run a cell against the local kernel. Everything seems fine.
  • At some point you're interrupted with a modal dialog with the message Failed to connect to the remote jupyter server. View Jupyter log for further details

Suggestions:

  • Don't asynchronously just show a modal dialog box. We need to find a better way to notify the user when this happens. I'd say they don't need to know until they try to choose a kernel.
  • Failed to fetch kernels from the remote jupyter server <name>. View Jupyter log for further details
    Where name is the Uri or the name provided for the connection (in the case of AML or the like).
  • Should we also include a button Disconnect from server?
@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Mar 1, 2022
@greazer greazer changed the title Review error message displayed when unable to connect to the remote jupyter server Adjust error notification behavior when unable to connect to the remote jupyter server Mar 1, 2022
@DonJayamanne DonJayamanne added this to the March 2022 milestone Mar 1, 2022
@rchiodo rchiodo modified the milestones: March 2022, April 2022 Mar 23, 2022
@DonJayamanne DonJayamanne self-assigned this Apr 7, 2022
@DonJayamanne

This comment was marked as resolved.

@DonJayamanne

This comment was marked as resolved.

@DonJayamanne
Copy link
Contributor Author

Solution: Display the kernels associated with the remote jupyter servers that are no longer valid. Once the user attempts to run a cell against one of these kernels, notify the user about the fact that the server is no longer recheable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants