Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document selector is just strings #9

Closed
jrieken opened this issue Dec 14, 2015 · 3 comments
Closed

document selector is just strings #9

jrieken opened this issue Dec 14, 2015 · 3 comments
Assignees
@dbaeumer
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone
January 2017

Comments

@jrieken
Copy link
Member

jrieken commented Dec 14, 2015

I can't register for a pattern etc
@dbaeumer dbaeumer added the bug Issue identified by VS Code Team member as probable bug label Dec 15, 2015
@dbaeumer dbaeumer added this to the Jan 2016 milestone Dec 15, 2015
@dbaeumer dbaeumer self-assigned this Dec 15, 2015
@BoykoAlex
Copy link

BoykoAlex commented Sep 22, 2016 •
edited

I'm trying to add language server support for various flavours of YAML files: Spring Boot application properties YAML, Cloud Foundry application deployment manifest YAML etc. Each of these different flavours of YAML should get its own validation/reconciling, content assist, hovers etc.
The only way to accomplish this is pass documentSelector parameter with DocumentFilter object that has a pattern property such that i can at least provide differrent YAML support for different YAML file names. LanguageClientOptions only accepts string|string[] :-(
Should be relatively straight-forward to make LanguageClient support documentSelector with DocumentFilter values (DocumentSelector: string | DocumentFilter | string | DocumentFilter[])... In fact all features are supported already except for doc changes synchronization code.
Any chance this can be fixed soon?

@dbaeumer
Copy link
Member

A started to work on this in master.

@dbaeumer dbaeumer modified the milestones: November 2016, Jan 2016 Oct 14, 2016
@dbaeumer
Copy link
Member

dbaeumer commented Feb 1, 2017

This got addressed in 3.0.x

@dbaeumer dbaeumer closed this as completed Feb 1, 2017
@dbaeumer dbaeumer modified the milestones: January 2017, November 2016 Feb 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dbaeumer dbaeumer

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
January 2017
Development

No branches or pull requests
3 participants
@jrieken @dbaeumer @BoykoAlex