Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve experience when using Codespaces #111

Open
andreamah opened this issue Jul 23, 2021 · 1 comment
Open

Improve experience when using Codespaces #111

andreamah opened this issue Jul 23, 2021 · 1 comment
Assignees
Labels
feature-request Request for new features or functionality
Milestone

Comments

@andreamah
Copy link
Contributor

Currently, as mentioned in #58, the embedded preview will not immediately work in Codespaces upon first launching (or sometimes just upon forwarding a port). This is because the content at the local address is not actually available until the user goes through some redirects in their browser. Since one of these redirects is github.com and github can't be framed in an iframe, it shows an error.

There isn't a way to see whether this failure happened from the extension side, so it's difficult to implement some type of fix upon failure.

Without help from the GitHub side in regards to detecting whether these redirects have happened and no way to perform the redirects programmatically, we could probably do something like:

  • Upon port forwarding, show an info message containing a link to tell you how to get around the issue OR a button that runs the open external preview command immediately. There should be a "don't show again" on this and perhaps some info on how to fix the issue yourself. However, I'm not too sure if there's currently an API to show a warning message, as PortAttributes does not seem to support this.

In the most ideal case, we would have a way to programmatically trigger the redirects, although they are most likely there for a reason (security, cookies).

@andreamah andreamah added the feature-request Request for new features or functionality label Jul 23, 2021
@mor10
Copy link

mor10 commented Apr 11, 2022

Bump.

The current workaround I've found is to open the preview tab (causes error), then use the context menu to open the preview in a separate tab (which actually works), then go back to Codespaces, close the preview tab, and re-open it using the right-click drop-down menu on the relevant document.

Being able to boot up a preview without having to jump through that many hoops would be great.

@andreamah andreamah added this to the August 2022 milestone Aug 8, 2022
@andreamah andreamah self-assigned this Aug 8, 2022
@andreamah andreamah modified the milestones: August 2022, September 2022 Aug 23, 2022
@andreamah andreamah removed this from the October 2022 milestone Oct 24, 2022
@andreamah andreamah added this to the November 2022 milestone Nov 7, 2022
@andreamah andreamah removed this from the November 2022 milestone Nov 29, 2022
@andreamah andreamah added this to the December 2021 milestone Dec 8, 2022
@andreamah andreamah modified the milestones: February 2023, March 2023 Feb 21, 2023
@andreamah andreamah modified the milestones: March 2023, On Deck Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants