Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Local] String “The pre-configure succeeded” and “The post-configure succeeded” not localized in Makefile tools output window #636

Closed
Yingzi1234 opened this issue Aug 7, 2024 · 1 comment
Labels
bug Something isn't working localization Bug or enhancement related to localization

Comments

@Yingzi1234
Copy link
Collaborator

Yingzi1234 commented Aug 7, 2024

More info:
1. This issue is reproduced on v0.9.10(release), so it is not a regression issue
2. Repro Language: all loc
3. Repro platform: Windows, Linux, Mac

Repro steps:

  1. Open VScode and change the display language to CHS
  2. Open VSCode and clone the repository, such as: https://github.com/remonbonbon/makefile-example.git
  3. Create a pre-configure file or post-configure, such as: “preConfigureScript.bat”
  4. Copy the contents: ECHO “PRECONFIGURE” %~1 to this file
  5. Copy this file's path to the "Makefile: Pre Configrue Script” settings
  6. Click F1 to run command "Makefile: Pre-configure"
  7. Check the output window

Expected result:
Makefile output log all localized

Actual result:
String “The pre-configure succeeded” and “The post-configure succeeded” not localized in Makefile tools output window

pre-configure:
image

post-configure:
image

@github-actions github-actions bot added the triage label Aug 7, 2024
@Yingzi1234 Yingzi1234 added bug Something isn't working localization Bug or enhancement related to localization and removed triage labels Aug 7, 2024
@gcampbell-msft
Copy link
Collaborator

Fixed by #634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working localization Bug or enhancement related to localization
Projects
None yet
Development

No branches or pull requests

2 participants