Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown syntax highlighter colors svg elements red #70

Open
shskwmt opened this issue Apr 2, 2020 · 3 comments
Open

Markdown syntax highlighter colors svg elements red #70

shskwmt opened this issue Apr 2, 2020 · 3 comments
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities
Milestone

Comments

@shskwmt
Copy link

shskwmt commented Apr 2, 2020

This was previously opened in microsoft/vscode#93650

@zigomir
Copy link

zigomir commented Jun 30, 2020

Same issue is bugging me. Not sure why it was reported in textmate/html.tmbundle#108 – I doubt VSCode relies on textmate that much :)

It's quite coupled to the theme though, I can reproduce it on most themes, except: Kimbie Dark, but even there, it's most probably by chance because sam color is used.

@mjbvz
Copy link
Contributor

mjbvz commented Oct 14, 2020

This grammar rule from html seems to be incorrectly be applying:

https://github.com/microsoft/vscode/blob/18bab626b9d54e836412b7a6aae620645da0422c/extensions/html/syntaxes/html.tmLanguage.json#L1085

Not sure why this is happening vs in normal html files

@mjbvz mjbvz added the help wanted Issues identified as good community contribution opportunities label Jun 3, 2022
@Strandinator
Copy link

Not sure if it's relevant.
In textmate/html.tmbundle#108 I mentioned that this also applies to html tags inside a foreignObject:

<svg><foreignObject><div></div></foreignObject></svg>

@mjbvz mjbvz added this to the Backlog milestone Dec 5, 2022
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants