-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maven output does not write to the VSC terminal window #489
Comments
The command is expected to run on integrated terminal withing vscode.
|
This issue has been closed automatically because it needs more information and has not had recent activity. Please reach out if you have or find the answers we need so that we can investigate further. |
@RedWingBB |
Thanks for the reply |
If the ".cmd" file extension is not specified, powershell will run a CMD propmt in a new window. What you can do nowAppend ".cmd" to "mvn", that it, to set |
Fixed in #499 |
Adding .cmd did it |
@Eskibear Since the last update of VSCode (August 2021 – 1.60) I'm facing this issue too. Maven is forced inside a Powershell integrated terminal (although my default terminal is cmd) and run the following command : Adding a Working on Windows 10. Executed mvn through a right click to the Maven project and used a favourite command defined in |
It's possible that vscode has changed something. Reading release note of the August version, you'll find recently they have been working on terminal related improvement.
True, I can reproduce it.
I cannot reproduce it, what's your The "&" was added here when powershell was detected as default shell: vscode-maven/src/mavenTerminal.ts Lines 101 to 103 in 64d5764
And the terminal is created using vscode's API, which should also use default shell. You mentioned a Powershell was used, and that looks consistent with above "&" behavior. The problem is, why ".cmd" was not appended to your "mvn". Because it's also intentionally done for Powershell in #499 vscode-maven/src/mavenTerminal.ts Lines 59 to 69 in 64d5764
Actions for you to takePlease help to check below:
|
I have downloaded my Maven version here and it doesn't provide a |
@Nicryc Thanks for the information. I can reproduce it now.
True. The problem is maven-3.2.5 use For the moment you can set |
@Nicryc I simply provided a fix appending ".bat" or ".cmd" accordingly, covering your case. Please kindly let me know if that works for you. Thanks. |
will be shipped in 0.34.0. To verify:
|
mitigated in v0.34.0 |
Ok this is working like a charm. Thanks. |
When I run maven/package a new cmd window is launched and the build output is written to it
I right click the maven project, then Package
A cmd window pops up
The build output streams into it
Then the cmd window closes
This makes it difficult to see if the build succeeded, what were the problems, so on
It may be there is a configuration option in the plugin or in VSC itself that I havent found
Environment is an admin login on Windows Server 2090
Uploading a screen shot, I hope it shows up.
The text was updated successfully, but these errors were encountered: