Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open POM under local maven repo in read-only mode #718

Closed
Eskibear opened this issue Aug 23, 2021 · 4 comments · Fixed by #734
Closed

open POM under local maven repo in read-only mode #718

Eskibear opened this issue Aug 23, 2021 · 4 comments · Fixed by #734
Labels
feature-request New feature or request
Milestone

Comments

@Eskibear
Copy link
Member

It's a follow-up item of #428

So far vscode has no such API, but we can workaround it via ContentProvider API, the same way we show effectivePOM and dependency list now.

@Eskibear Eskibear added the feature-request New feature or request label Aug 23, 2021
@Eskibear Eskibear added this to the backlog milestone Aug 23, 2021
@Eskibear Eskibear modified the milestones: backlog, 0.34.0 Sep 1, 2021
@Eskibear
Copy link
Member Author

To verify:

  1. Open a Maven project
  2. hover on a dependency node, press "ctrl" and click
  3. it should open corresponding .pom file in readonly mode.

Note: if "version" is not directly specified in dependency node, you should calculate its effective pom first.

@gigitacoo
Copy link

Sorrry for reply in a closed issue, But i tried press "command" and click on a dependency and it raises an error like this:

`Unable to open 'pring-boot-starter-test-2.2.4.RELEASE.pom': Unable to read file '/Users/hilion/.m2/repository/org/springframework/boot/spring-boot-starter-test/2.2.4.RELEASE/spring-boot-starter-test-2.2.4.RELEASE.pom' (Error: Unable to resolve non-existing file '/Users/hilion/.m2/repository/org/springframework/boot/spring-boot-starter-test/2.2.4.RELEASE/spring-boot-starter-test-2.2.4.RELEASE.pom').

settings.xml set local repository is :
/Users/hilion/Public/repo`

Specifies the location of the settings.xml
图片

version:
version: 1.63.1 (Universal)
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 18.5.0

Thank you for your efforts

@Eskibear
Copy link
Member Author

@gigitacoo These two settings are defined by extension "Language Support for Java", (see https://github.com/redhat-developer/vscode-java#supported-vs-code-settings ) which is responsible for importing and compiling Maven project, and providing intellisense.

This Maven extension doesn't honor above two settings (at least for now), please use maven.settingsFile, see https://github.com/microsoft/vscode-maven#settings

@gigitacoo
Copy link

@Eskibear
Got it, it works for the dependency which has specified version tag, thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants