Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native VScode on M1 (Apple Silicon) breaks extension #16967

Closed
roelrens opened this issue Mar 9, 2021 · 9 comments · Fixed by #17613
Closed

Native VScode on M1 (Apple Silicon) breaks extension #16967

roelrens opened this issue Mar 9, 2021 · 9 comments · Fixed by #17613

Comments

@roelrens
Copy link

roelrens commented Mar 9, 2021

  • MSSQL Extension Version:v1.10.1
  • VSCode Version: 1.55.0-insider (Universal)
  • OS Version: 11.2.3 (20D91)

Steps to Reproduce:

  1. use the universal binary of VSCode
  2. extension support broken.
@abist abist added the Bug label Mar 10, 2021
@davemcdermid
Copy link
Contributor

Looks like this is can be fixed with a small change to platform mapping, I've created a PR: #16969

@leighghunt
Copy link

I've just run into this whilst setting up a new M1 Air - can help test if required

@dzsquared
Copy link
Contributor

There is now a preview release available here: https://github.com/microsoft/vscode-mssql/releases/tag/v1.10.2

Next stable release is planned for end of October

@brunovieira97
Copy link

Any news on this?

@leighghunt
Copy link

Any news on this?

I'm not on the team or anything, but I'm successfully using v1.13.0, just downloaded from the marketplace if I recall correctly - and i can see the change that was made is in the v1.13.0 code branch - https://github.com/microsoft/vscode-mssql/blob/v1.13.0/src/models/platform.ts#L292

@brunovieira97
Copy link

@leighghunt I see. Thanks for the heads up. I was checking up on this because it seems to be a dependency for Azure Data Studio to be properly ported to Apple Silicon. Glad to know this is taken care of.

@davemcdermid
Copy link
Contributor

The PR I created was merged and released, which allows the extension to run through Rosetta2, but would be great if the library were ported to run natively.

@nick-gibb
Copy link

+1, would be great if we could get this to run using ARM64.

@Nova-Logic
Copy link

+1 waiting m1 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

9 participants