Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User belongs to all controls in experiment #11943

Closed
DonJayamanne opened this issue May 21, 2020 · 2 comments
Closed

User belongs to all controls in experiment #11943

DonJayamanne opened this issue May 21, 2020 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@DonJayamanne
Copy link

Here's my output from Python output panel:

User belongs to experiment group 'ShowPlayIcon - start'
User belongs to experiment group 'ShowExtensionSurveyPrompt - control'
User belongs to experiment group 'DebugAdapterFactory - experiment'
User belongs to experiment group 'PtvsdWheels37 - experiment'
User belongs to experiment group 'LS - control'
User belongs to experiment group 'UseTerminalToGetActivatedEnvVars - control'
User belongs to experiment group 'WebHostNotebook - control'
User belongs to experiment group 'LocalZMQKernel - experiment'
User belongs to experiment group 'LocalZMQKernel - control'
User belongs to experiment group 'NativeNotebook - experiment'
User belongs to experiment group 'NativeNotebook - control'
User belongs to experiment group 'CollectLSRequestTiming - control'
User belongs to experiment group 'CollectNodeLSRequestTiming - experiment'
User belongs to experiment group 'EnableIPyWidgets - experiment'
User belongs to experiment group 'RunByLine - control'

As you can see I belong to the experiment and control group for two experiments LocalZMQKernel & NativeNotebook.

Here's my settings.json file

	"python.experiments.optInto": [
		"LocalZMQKernel - experiment",
		"NativeNotebook - experiment"
	],

I think we need to first check the opted in exepriments & then process the other list, and track the user experiments based on the experiment salt. This way they cannot belong to both control and experiment.
Also, we need to ensure opt in experiment takes precedence.

@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team labels May 21, 2020
@DonJayamanne DonJayamanne self-assigned this May 21, 2020
@karthiknadig
Copy link
Member

/cc @karrtikr If I remember correctly this is a logging issue. As for the experiment, the priority is given to python.experiments.optInto. So you belong to that experiment. This is a known issue with the logging.

@DonJayamanne
Copy link
Author

DonJayamanne commented May 21, 2020

This is a known issue with the logging.

No, its not an issue with logging, the user is actually added into both experiment groups.
I have a fix ready.

@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label May 24, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants