Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hot exit in VSC Notebook and custom editor do not work as expected #994

Closed
DonJayamanne opened this issue Jun 16, 2020 · 1 comment
Closed

Hot exit in VSC Notebook and custom editor do not work as expected #994

DonJayamanne opened this issue Jun 16, 2020 · 1 comment
Assignees
@DonJayamanne

Comments

@DonJayamanne
Copy link
Contributor

Basically the hoteixt file gets deleted.
Only applies to custom editor and VSC Notebooks.
@DonJayamanne DonJayamanne self-assigned this Jun 16, 2020
DonJayamanne referenced this issue in microsoft/vscode-python Jun 16, 2020
@DonJayamanne
Change hot exit to create new files for each backup (#12377)
c646c19 
For #12376
For #10496

Changes due to the way VSC works.

After VSC calls the backup method, the previous backup is deleted.
This means each backup is unique (hence the backup id must be unique)
Fix for VSC Notebooks and Custom Editor
@greazer greazer closed this as completed Jun 18, 2020
@TheCleric
Copy link

This appears to still be an issue for me.

OS: Windows 10
VS Code version: 1.48.2
VS Code Python Version: 2020.8.103604

Reproduction steps:
Open an existing .ipynb file or "Python: Create New Blank Jupyter Notebok"
Add a change (such as a comment)
Close VS Code
Reopen VS Code

Result: Change has been discarded
Expected Result: Change has been preserved (but not saved to the file)

@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 11, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TheCleric @DonJayamanne @greazer