Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate editor.formatOnType validity using Python's test grammar #1354

Closed
brettcannon opened this issue Apr 9, 2018 · 2 comments · Fixed by #1450
Closed

Validate editor.formatOnType validity using Python's test grammar #1354

brettcannon opened this issue Apr 9, 2018 · 2 comments · Fixed by #1450
Assignees
Labels
area-formatting debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone

Comments

@brettcannon
Copy link
Member

https://github.com/python/cpython/blob/master/Lib/test/test_grammar.py

We should run this file through tests at least once to make sure things work, but it's probably better to write a test for this as well to prevent regressions (we will need to make sure to update it for each new release of Python).

@brettcannon brettcannon added needs verification debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-formatting labels Apr 9, 2018
@brettcannon brettcannon added this to the April 2018 milestone Apr 9, 2018
@brettcannon
Copy link
Member Author

And if we do embed the file as a test then we will need to add the Python license appropriately.

@brettcannon
Copy link
Member Author

I found another bug in the editor.formatOnType support, so doing this validation is getting important.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-formatting debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants