Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows unit tests to the PR validation pipeline #14013

Closed
kimadeline opened this issue Sep 21, 2020 · 3 comments
Closed

Add Windows unit tests to the PR validation pipeline #14013

kimadeline opened this issue Sep 21, 2020 · 3 comments
Assignees
@kimadeline
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority

Comments

@kimadeline
Copy link

kimadeline commented Sep 21, 2020 •
edited
Loading

The PR pipeline currently only runs the following Windows test suites:

  • Functional
  • Single workspace

Having the unit tests suite run on Windows would have helped with catching #14011 earlier.
@kimadeline kimadeline added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. triage-needed Needs assignment to the proper sub-team labels Sep 21, 2020
@karthiknadig
Copy link
Member

It was removed cause it takes too long.

@kimadeline
Copy link
Author

The unit tests or the entire suite?

@karthiknadig
Copy link
Member

The entire windows suite used to take too long. We can bring in 3x Unit tests (it takes about 35 mins)

@karthiknadig karthiknadig added area-internal Label for non-user facing issues needs PR labels Sep 22, 2020
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Sep 22, 2020
@karthiknadig karthiknadig added the important Issue identified as high-priority label Sep 22, 2020
@kimadeline kimadeline mentioned this issue Sep 25, 2020
Merged
10 tasks
@kimadeline kimadeline self-assigned this Sep 25, 2020
@luabud luabud closed this as completed Sep 30, 2020
@ghost ghost removed the needs PR label Sep 30, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kimadeline kimadeline

Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karthiknadig @luabud @kimadeline