Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When isort outputs a warning message, do not discard the diff and report a failure #14066

Closed
kimadeline opened this issue Sep 23, 2020 · 1 comment
Closed

When isort outputs a warning message, do not discard the diff and report a failure #14066

kimadeline opened this issue Sep 23, 2020 · 1 comment
Labels
feature-request Request for new features or functionality

Comments

@kimadeline
Copy link

from @Lexicality in #13948 (comment):

Would it be possible to improve the error messages caused when isort fails to explain the problem? I would normally expect a warning not to fail an action.

When running isort, we expect it to return a diff. However, if any other message is sent, we will treat it as a failure and discard all changes.

The message can be anything, in the case of #12949 and #13948 (comment) it is just a warning, which isn't expected to cause isort to fail.
@kimadeline kimadeline added feature-request Request for new features or functionality triage-needed Needs assignment to the proper sub-team labels Sep 23, 2020
@kimadeline kimadeline mentioned this issue Sep 23, 2020
Closed
@kimadeline kimadeline changed the title Do not discard the diff and report a failure when isort outputs a warning message When isort outputs a warning message, do not discard the diff and report a failure Sep 23, 2020
@karthiknadig
Copy link
Member

Closing in favour of #14085

@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Sep 24, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karthiknadig @kimadeline