Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rediscovery of tests which where not changed should not become unknown (?) #15281

Closed
chanansh opened this issue Jan 31, 2021 · 3 comments
Closed
Labels
area-testing feature-request Request for new features or functionality

Comments

@chanansh
Copy link

In respect to #9606, in my humble opinion, I think it is very annoying to lose all your test status just because you have added one test. So, assume that you have written 100 tests, 80 passes, 20 failed. You are adding the 101 test and then you are losing which tests are yet to be solved (the 20/100 or more correctly 20/101 now that you have a new test.). If testing takes time, you need now to wait an hour or so to get again the list of failed tests. I suggest a checkbox which "keeps" the state and then "refresh" only add new/remove tests

@isidorn I feel that if test discovery is triggered, it should refresh the state of the tests (and that's also the reason why we chose the "refresh" icon for this). If the user makes changes and triggers test discovery again, retaining the previous state will show now an incorrect state. If the name of the test changes as well as its result, what would be the expected state, in this case?
Personally, I think "unknown" makes sense for all of these cases.
Anyway, tagging it as "needs decision" so I can talk to the team about it 😊

Originally posted by @luabud in #9606 (comment)

@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Jan 31, 2021
@isidorn
Copy link

isidorn commented Feb 1, 2021

Idealy in the future the test view would use our newly introduced test view by @connor4312 instead of a custom solution

@karthiknadig karthiknadig added area-testing needs decision feature-request Request for new features or functionality labels Feb 1, 2021
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Feb 1, 2021
@karthiknadig
Copy link
Member

Thank you for the suggestion! We have marked this issue as "needs decision" to make sure we have a conversation about your idea. We plan to leave this feature request open for at least a month to see how many 👍 votes the opening comment gets to help us make our decision.

@luabud
Copy link
Member

luabud commented Mar 24, 2021

Closing in favour of #15750

@luabud luabud closed this as completed Mar 24, 2021
@ghost ghost removed the needs decision label Mar 24, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants