Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Clear Workspace Interpreter Setting" removes comments before and after "python.pythonPath" #16310

Closed
bersbersbers opened this issue May 24, 2021 · 1 comment
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@bersbersbers
Copy link

bersbersbers commented May 24, 2021

Environment data

  • VS Code version: 1.56.2
  • Extension version (available under the Extensions sidebar): v2021.5.842923320
  • OS and version: Windows, Remote SSH into Linux

Expected behaviour

Comments should not be removed from the workspace configuration.

Actual behaviour

Comments are removed from the workspace configuration.

Steps to reproduce:

  1. Have this in your .code-workspace file:
    // comment
    "settings": {
        // comment
        // comment
        "python.pythonPath": "whatever",
        // comment
        // comment
        "abc.def": "/next/setting",
        // comment
        ...
    }
  1. Call "Clear Workspace Interpreter Setting"

image

Closely related: microsoft/vscode#29453

@bersbersbers bersbersbers added triage-needed Needs assignment to the proper sub-team bug Issue identified by VS Code Team member as probable bug labels May 24, 2021
@karrtikr
Copy link

Closing as dup of microsoft/vscode#29453. We rely on VSCode API which does this.

@karthiknadig karthiknadig removed the triage-needed Needs assignment to the proper sub-team label May 24, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

3 participants