Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jedi LS: Cannot disable language server linting #17777

Open
dp-alvarez opened this issue Oct 18, 2021 · 6 comments
Open

Jedi LS: Cannot disable language server linting #17777

dp-alvarez opened this issue Oct 18, 2021 · 6 comments
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug community ask Feature request that the community expressed interest in needs proposal Need to make some design decisions

Comments

@dp-alvarez
Copy link

Environment data

  • VS Code version: 1.61
  • Extension version: v2021.10.1336267007
  • Value of the python.languageServer setting: Jedi

Expected behaviour

When using the Jedi language server, all of the linting-related settings to are only applied to "external" linting tools.
None of the settings affect the problems reported by the language server, which create invalid entries in the problems panel in my project.

Actual behaviour

Provide some option to filter language server provided problems. Either as a new setting or integrate the functionality in one of the existing settings, such as "python.linting.ignorePatterns", "python.linting.enabled", etc.

@dp-alvarez dp-alvarez added bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team labels Oct 18, 2021
@karthiknadig karthiknadig changed the title Cannot disable language server linting Jedi LS: Cannot disable language server linting Oct 18, 2021
@karthiknadig karthiknadig self-assigned this Oct 18, 2021
@karthiknadig karthiknadig added area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. triage and removed triage-needed Needs assignment to the proper sub-team labels Oct 18, 2021
@karthiknadig
Copy link
Member

We need to update these options for Jedi here:

diagnostics: {
enable: true,
didOpen: true,
didSave: true,
didChange: true,
},

That method already has the settings, we just need to read pythonSettings.linting.enabled and set the appropriate values.

@dp-alvarez
Copy link
Author

Appreciate the very quick response!

Looking further into the settings, I think there are other settings better suited to implement this behavior than "python.linting.enabled", since one could want to disable language server linting but still enable external tools such as pylint.

I think either creating a new setting or adding a wildcard option to "python.analysis.disabled" so it disables all error messages would work better.

@karthiknadig karthiknadig added needs proposal Need to make some design decisions and removed good first issue needs PR labels Oct 18, 2021
@karthiknadig
Copy link
Member

Yes, I agree. Switched this to needs proposal so we can discuss this internally to see what setting to add for this. If this is a new setting then we will have to coordinate with Jedi (LS project https://github.com/pappasam/jedi-language-server) and Pylance (https://github.com/microsoft/pylance-release/)

@karthiknadig karthiknadig removed their assignment Oct 19, 2021
@dp-alvarez
Copy link
Author

Hi, I'd like to know if this is still being worked on.

Sometimes jedi doesn't detect problems correctly (which is bound to happen with languages such as python) and at the moment the only solution is to disable the language server entirely, which reduces vscode to a 'dumb' text editor.

A lot of folks rely on external linting tools and the built-in language server linting causes problems while providing no benefit.

Thanks!

@MattTunny
Copy link

yeah im getting the same issue, having to completely uninstall the linter to turn it off.

@tmchartrand
Copy link

agreed, would be great to have "python.linting.ignorePatterns" supported for Jedi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug community ask Feature request that the community expressed interest in needs proposal Need to make some design decisions
Projects
None yet
Development

No branches or pull requests

5 participants