Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out interpreter path related settings from general configuration service #17821

Closed
karrtikr opened this issue Oct 20, 2021 · 1 comment
Closed
Labels
area-environments Features relating to handling interpreter environments debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@karrtikr
Copy link

karrtikr commented Oct 20, 2021

Ideally we should separate each setting type to its own component. But for now interpreter path settings has grown to have a lot of special cases in configSettings.ts.

@karrtikr karrtikr added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-environments Features relating to handling interpreter environments labels Oct 20, 2021
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Oct 20, 2021
@karrtikr karrtikr removed the triage-needed Needs assignment to the proper sub-team label Oct 20, 2021
@karrtikr karrtikr changed the title Split out interpreter path related settings from Configuration service Split out interpreter path related settings from general configuration service Oct 20, 2021
@github-actions github-actions bot removed the needs PR label Aug 9, 2022
@karrtikr karrtikr added the needs PR Ready to be worked on label Aug 9, 2022
@karrtikr
Copy link
Author

karrtikr commented Nov 2, 2023

Actually, every component should have it's own settings class. Just having an issue open for interpreter setting seems not so useful. We can do this as and when we split the extension up.

@karrtikr karrtikr closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2023
@github-actions github-actions bot removed the needs PR Ready to be worked on label Nov 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-environments Features relating to handling interpreter environments debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

No branches or pull requests

1 participant