Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Refresh tests" button missing when telemetry is disabled #17868

Closed
trevor87 opened this issue Oct 28, 2021 · 11 comments · Fixed by #17894
Closed

"Refresh tests" button missing when telemetry is disabled #17868

trevor87 opened this issue Oct 28, 2021 · 11 comments · Fixed by #17894
Assignees
Labels
area-testing bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@trevor87
Copy link

Environment data

  • VS Code version: 1.61.2
  • Extension version (available under the Extensions sidebar): v2021.10.1365161279
  • OS and version: Ubuntu 20.04
  • Python version (& distribution if applicable, e.g. Anaconda): Python 3.8.10
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
  • Value of the python.languageServer setting: "Default"

Expected behaviour

I should be able to see the "refresh tests" button in the testing section with telemetry disabled. Expected:
grafik

Actual behaviour

When I set the settings.json like this:

{
    "telemetry.telemetryLevel":"off",
}

the refresh tests button disappears like so:
grafik

Steps to reproduce:

  1. Open VSCode with an empty settings.json like so:
{
}

Now check the tests -> the button is there.

  1. Modify the settings.json as stated above, save and restart vscode.
    -> The button is now gone
@trevor87 trevor87 added bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team labels Oct 28, 2021
@karrtikr
Copy link

Thanks for opening the issue. Actually the feature you mentioned is behind an experiment,

export enum ShowRunFailedTests {
experiment = 'pythonRunFailedTestsButtonDisplayed',
}
// Experiment to show the run failed tests button
export enum ShowRefreshTests {
experiment = 'pythonRefreshTestsButtonDisplayed',
}

and disabling telemetry effectively opts out users from experiments.

We plan to soon remove the experiment, which means the new behavior will be available to all users regardless of their experiment or telemetry settings.

cc / @karthiknadig Should we do it as part of this issue?

@karthiknadig
Copy link
Member

@luabud Can we remove the buttons experiment?

@karrtikr Yes. We can do that as a part of this issue.

@trevor87
Copy link
Author

Thanks for clarifying! I was suspecting that it might have something to do with experiments but did not know that telemetry also disables those.

@karthiknadig karthiknadig self-assigned this Nov 1, 2021
@karthiknadig karthiknadig added area-editor-* User-facing catch-all needs PR area-testing and removed triage-needed Needs assignment to the proper sub-team area-editor-* User-facing catch-all labels Nov 1, 2021
@karthiknadig karthiknadig added this to the November 2021 milestone Nov 2, 2021
@jzazo
Copy link

jzazo commented Nov 17, 2021

Hi! I still don't see the button, but I see that the experiment has been closed. How can I get the refresh button back? Do we have to wait till November's release? Thanks.

@karrtikr
Copy link

You can use Python: Switch to Insiders commands to install the latest insiders version of the extension. Otherwise the stable release for November should also have this fix.

@karthiknadig karthiknadig added the verified Verification succeeded label Nov 29, 2021
@jzazo
Copy link

jzazo commented Dec 9, 2021

I installed the stable November release today, but the refresh button still does not show. Any way to check why it doesn't or enable it? Thanks.

@karrtikr
Copy link

karrtikr commented Dec 9, 2021

It has not been released yet I think, it should be out by end of this week, are you on the latest VSCode version?

@jzazo
Copy link

jzazo commented Dec 9, 2021

I updated today and it lists 1.63.0 on the About window.

@karrtikr
Copy link

karrtikr commented Dec 9, 2021

Then you should be getting it soon.

@jzazo
Copy link

jzazo commented Dec 10, 2021

The icon appeared today. Thanks!

@karrtikr
Copy link

Great!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants