Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommendation patterns recommend to linting and formatting extensions #21458

Closed
karthiknadig opened this issue Jun 20, 2023 · 10 comments · Fixed by microsoft/vscode#185697
Closed
Assignees
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@karthiknadig
Copy link
Member

karthiknadig commented Jun 20, 2023

Testing:

  1. Add pyproject.toml to a workspace with following content:
[tool.ruff]
  1. Reload.
  2. you should see Ruff extension in the recommended extensions.

image

@karthiknadig karthiknadig added the feature-request Request for new features or functionality label Jun 20, 2023
@karthiknadig karthiknadig added this to the June 2023 milestone Jun 20, 2023
@karthiknadig karthiknadig self-assigned this Jun 20, 2023
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jun 20, 2023
@karthiknadig
Copy link
Member Author

@charliermarsh FYI 😊

@charliermarsh
Copy link

Woahhh, so cool! Thanks @karthiknadig!

@karthiknadig karthiknadig added verification-needed Verification of issue is requested needs PR Ready to be worked on and removed triage-needed Needs assignment to the proper sub-team labels Jun 26, 2023
@rebornix rebornix added the verified Verification succeeded label Jun 27, 2023
@rebornix
Copy link
Member

image

I'm not seeing Ruff being recommended.

@rebornix rebornix reopened this Jun 27, 2023
@rebornix rebornix added verification-found Issue verification failed and removed verified Verification succeeded labels Jun 27, 2023
@karthiknadig
Copy link
Member Author

@rebornix did you reload after making the change to the file?

@karthiknadig
Copy link
Member Author

Seems to work after reload.
image

The recommendations are searched for on load, so if you make a change to a file later they are not detected. May be a feature.
/cc @sandy081

@rebornix
Copy link
Member

@karthiknadig yes I reloaded multiple times, but it never show up.

@karthiknadig
Copy link
Member Author

This seems to be a bug on VS Code, as the patterns seem to work for me on Windows and linux, on following insiders:
Version: 1.80.0-insider (user setup)
Commit: da7f05a70eb760e4ce1fe230ae158ae214433341
Date: 2023-06-27T15:13:35.848Z
Electron: 22.3.14
ElectronBuildId: 21893604
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Windows_NT x64 10.0.19045

@karthiknadig
Copy link
Member Author

@rebornix Can you confirm that the file is located in the workspace root?

@sandy081
Copy link
Member

This recommendations view is a mix of all kinds of recommendations and therefore it filters out some non important ones and show only a subset. Hence I would recommend to check the following view

image

@rebornix
Copy link
Member

@karthiknadig ah ha, good catch, I have it in a sub folder. I guess this is as expected.

@rebornix rebornix added verified Verification succeeded and removed verification-found Issue verification failed labels Jun 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2023
@eleanorjboyd eleanorjboyd removed the needs PR Ready to be worked on label Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants