Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate how to handle Create Environment when called with a preexisting environment #21587

Closed
luabud opened this issue Jul 8, 2023 · 3 comments
Assignees
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality

Comments

@luabud
Copy link
Member

luabud commented Jul 8, 2023

No description provided.

@luabud luabud added the feature-request Request for new features or functionality label Jul 8, 2023
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jul 8, 2023
@luabud luabud added needs proposal Need to make some design decisions area-environments Features relating to handling interpreter environments and removed triage-needed Needs assignment to the proper sub-team labels Jul 8, 2023
@karthiknadig
Copy link
Member

@eleanorjboyd
Copy link
Member

seems similar to #19935. We should add a note in the logs / prompt that we are selecting the existing environment. This investigation could also determine a different direction in terms of the mentioning

@luabud
Copy link
Member Author

luabud commented Dec 21, 2023

I think think we may close this. Right now when there's an environment in the workspace we show two options: either to select the existing one, or to delete and recreate it. When one selects "use existing", we show a confirmation prompt saying that's selected.

image

We could be more explicit in the logs though, so we can leave #19935 open :)

What we show in the logs:

2023-12-20 17:34:10.359 [info] Selected workspace /home/x for creating virtual environment.
2023-12-20 17:34:11.202 [info] Selected interpreter /home/x/.venv/bin/python for creating virtual environment.

@luabud luabud closed this as completed Dec 21, 2023
@github-actions github-actions bot removed the needs proposal Need to make some design decisions label Dec 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants