Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "invalid interpreter" notification to a modal dialog #23432

Open
luabud opened this issue May 14, 2024 · 1 comment
Open

Change "invalid interpreter" notification to a modal dialog #23432

luabud opened this issue May 14, 2024 · 1 comment
Assignees
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality needs PR Ready to be worked on

Comments

@luabud
Copy link
Member

luabud commented May 14, 2024

Right now when there's an invalid interpreter selected for the workspace and you try to run a file or start the REPL, for example, we display an error notification. Feedback from the broader team was that we should probably change it to a modal dialog since it's an "blocking" error, to drive higher discoverability of the failure point.

@luabud luabud added feature-request Request for new features or functionality area-environments Features relating to handling interpreter environments needs PR Ready to be worked on labels May 14, 2024
@anthonykim1 anthonykim1 self-assigned this May 14, 2024
@luabud
Copy link
Member Author

luabud commented May 14, 2024

I think this is an example of a modal dialog in the Jupyter extension: https://github.com/microsoft/vscode-jupyter/blob/main/src/notebooks/controllers/commands/installPythonControllerCommands.ts#L52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality needs PR Ready to be worked on
Projects
None yet
Development

No branches or pull requests

2 participants