Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refactoring features like change in file, module and variable names #1510

Closed
qb-tarushg opened this issue Mar 4, 2019 · 13 comments
Closed
Labels
enhancement New feature or request

Comments

@qb-tarushg
Copy link

Environment data

  • VS Code version: XXX
  • Extension version (available under the Extensions sidebar): XXX
  • OS and version: XXX
  • Python version (& distribution if applicable, e.g. Anaconda): XXX
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): XXX
  • Relevant/affected Python packages and their versions: XXX

Expected behaviour

XXX

Actual behaviour

XXX

Steps to reproduce:

  1. XXX

Logs

Output for Python in the Output panel (ViewOutput, change the drop-down the upper-right of the Output panel to Python)

XXX

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help; turn on source maps to make any tracebacks be useful by running Enable source map support for extension debugging)

XXX
@qb-tarushg qb-tarushg changed the title Add refactoring features like change in file name, module name, function name, signature will result in change in their references [Feature] Request to add refactoring features like change in file name, module name, function name, signature will result in change in their references Mar 4, 2019
@DonJayamanne DonJayamanne changed the title [Feature] Request to add refactoring features like change in file name, module name, function name, signature will result in change in their references Add refactoring features like change in file name, module name, function name, signature will result in change in their references Mar 5, 2019
@DonJayamanne
Copy link
Collaborator

@qb-tarushg

  • Refactor rename file/module (this is new, and not yet supported)
  • Refactor rename function (this is currently supported)

@DonJayamanne DonJayamanne changed the title Add refactoring features like change in file name, module name, function name, signature will result in change in their references Add refactoring features like change in file name and module name Mar 5, 2019
@DonJayamanne DonJayamanne removed their assignment Mar 5, 2019
@ispmarin
Copy link

ispmarin commented Oct 6, 2019

👍

1 similar comment
@awaemmanuel
Copy link

👍

@HitLuca
Copy link

HitLuca commented Oct 30, 2019

Having to open PyCharm whenever I need to refactor some files is not the most efficient workflow

@luabud
Copy link
Member

luabud commented Nov 13, 2019

This should also captures variable name refactoring

@luabud luabud changed the title Add refactoring features like change in file name and module name Add refactoring features like change in file, module and variable names Nov 13, 2019
@astier
Copy link

astier commented Dec 2, 2019

Refactoring of a file should include renaming and moving it to another directory.

@ricky-lim
Copy link

👍

@mscipio
Copy link

mscipio commented May 8, 2020

This missing feature migth single-handedly send me back to PyCharm ... :\

@lescientifik
Copy link

To add to this topic, I have to say I switch from vs code to pycharm recently, despite loving code so far. The refactoring option in pycharm is indeed a killer feature, badly missing in vs code. That's too bad because vs code is way lighter, easier to use and uncluttered...

So +1 for this feature, would love to see this happen!

@akiyamasho
Copy link

+1 for this as well. I switched to VSCode since we use the Live Share a lot with my team, so having this would completely replace PyCharm for most devs

@brettcannon brettcannon transferred this issue from microsoft/vscode-python Jun 29, 2021
@jakebailey
Copy link
Member

Just to explicitly list things here:

@bschnurr bschnurr added the enhancement New feature or request label Jul 5, 2021
@github-actions github-actions bot removed the triage label Jul 5, 2021
@jakebailey
Copy link
Member

I think I'm going to close this in favor of #127 (as noted above); we're working on it.

@tomc-goodrx
Copy link

@jakebailey FWIW I'm pretty sure #127 won't solve the thing I need right now (that PyCharm does). That is breaking the stuff (functions, consts, classes, etc) up in some file into a bunch of smaller files and renaming the references.

It's pretty similar conceptually to rename symbol, but since each other file in the workspace has some reference to the current module it's mostly about easily updating those.

Since #127 operates on a file level I don't think it will help with actual refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests