Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade isort #6369

Closed
brettcannon opened this issue Jun 27, 2019 · 4 comments
Closed

Upgrade isort #6369

brettcannon opened this issue Jun 27, 2019 · 4 comments
Assignees
Labels
area-formatting debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority

Comments

@brettcannon
Copy link
Member

https://pypi.org/project/isort/4.3.21/

@brettcannon brettcannon added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-formatting important Issue identified as high-priority labels Jun 27, 2019
@thernstig
Copy link

@brettcannon I have a question here. https://code.visualstudio.com/docs/python/settings-reference#_refactoring-sort-imports-settings says Path to isort script for python.sortImports.path. Inside VS Code settings it says: // Path to isort script, default using inner version

What is "inner" version here. There is no mention of it in the docs. Because we have installed isort 4.3.21 in our project, but we have not set python.sortImports.path: "isort".

Does this mean we are not actually using version 4.3.21 but some hidden/"inner" version bundled with the Python extension.

Could the docs be more clear here?

@brettcannon
Copy link
Member Author

@thernstig we ship isort with the extension (the "inner" version you're asking about), but you can override it with your own copy of isort if you specify the appropriate setting. So if you haven't specified a path to isort then the extension is using its own copy.

If you have specific wording you think is better, please feel free to open an issue at https://github.com/microsoft/vscode-docs.

@luabud
Copy link
Member

luabud commented Jul 16, 2019

make sure to check if #2814 gets fixed by this

@ericsnowcurrently
Copy link
Member

I've verified that import are sorted correctly.

@ghost ghost removed the needs PR label Jul 29, 2019
@ericsnowcurrently ericsnowcurrently removed their assignment Jul 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-formatting debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority
Projects
None yet
Development

No branches or pull requests

5 participants