Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter: keep old issues list visible while running and preparing new ones #6579

Closed
technic opened this issue Jul 15, 2019 · 2 comments
Closed
Labels
area-linting feature-request Request for new features or functionality

Comments

@technic
Copy link

technic commented Jul 15, 2019

Hi,
I have the following workflow case which is currently a bit annoying in the vs code:

I have a linter (pylint in my case) set up and running. So, I have a list of issues reported and want to fix them one by one. I click on the first in the list, jump to the code and start fixing. If it is usual typo, style or white space bug I can do it in one second. But as soon as I've changed some code - Bam! the linter is restarted and all issues are gone. On a large file or codebase it may take around 10s to rerun pylint, and I have to stare at the blank screen waiting for next minor linter warning to reappear.

So my suggestion is the following: run the linter in the background but always show the last available output in the issues list. If it is not up to date mark it somehow (like grey out for example) while still allowing user to interact with it by jump to the line clicks.

@technic technic added triage-needed Needs assignment to the proper sub-team feature-request Request for new features or functionality labels Jul 15, 2019
@technic technic changed the title Linter: keep old issues list visible while running and preparing ones Linter: keep old issues list visible while running and preparing new ones Jul 15, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jul 15, 2019
@brettcannon brettcannon added triage-needed Needs assignment to the proper sub-team area-linting and removed triage-needed Needs assignment to the proper sub-team labels Jul 15, 2019
@brettcannon
Copy link
Member

@technic a work-around for this is to not have linting on save. That way you can manually run the linters when you're ready to check again.

@luabud
Copy link
Member

luabud commented Sep 17, 2019

Thanks for the suggestion 👍 but we decided not to move forward with this idea for now, since there is a workaround for it.

@luabud luabud closed this as completed Sep 17, 2019
@ghost ghost removed the needs decision label Sep 17, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-linting feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants