Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] Use conda run for running tools #7425

Closed
luabud opened this issue Sep 16, 2019 · 10 comments
Closed

[meta] Use conda run for running tools #7425

luabud opened this issue Sep 16, 2019 · 10 comments
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority meta Issue that is tracking an overall project

Comments

@luabud
Copy link
Member

luabud commented Sep 16, 2019

No description provided.

@luabud luabud added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. triage-needed Needs assignment to the proper sub-team labels Sep 16, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Sep 16, 2019
@luabud
Copy link
Member Author

luabud commented Sep 16, 2019

@luabud luabud changed the title Use conda run for running tools Use conda run for running tools Sep 16, 2019
@brettcannon brettcannon added this to the 2019 - September Sprint 2 milestone Sep 16, 2019
@DonJayamanne
Copy link

Isn't this a duplicate of #6010?

@luabud
Copy link
Member Author

luabud commented Sep 17, 2019

@DonJayamanne we separated the issues for running tools and for the debugger

@DonJayamanne
Copy link

DonJayamanne commented Sep 17, 2019

Added another item for running Jupyter (DataScience)

@DonJayamanne
Copy link

@luabud @brettcannon
I'd prefer to somehow implement this as an experiment.
I.e. roll this out slowly to users, rather than everyone in one go. This way we'll know whether it works or not. If it doesn't work or we have issues, then the number of users impacted is small.

@brettcannon
Copy link
Member

@DonJayamanne how is this not going to be an improvement from what we are doing now? conda run is the official way to do this sort of thing now, so I'm not seeing where the worry is about it being "wrong".

@DonJayamanne
Copy link

DonJayamanne commented Sep 19, 2019

I'm not seeing where the worry is about it being "wrong".

Just a fear of something going wrong. Nothing else. 😁

@karrtikr
Copy link

Meta issue

@karrtikr karrtikr added the meta Issue that is tracking an overall project label Sep 25, 2019
@ericsnowcurrently ericsnowcurrently changed the title Use conda run for running tools [meta] Use conda run for running tools Sep 25, 2019
@ericsnowcurrently
Copy link
Member

There is also a concern that "pythonPath" in debug config (see #7690) can conflict and cause a problem.

@luabud
Copy link
Member Author

luabud commented Oct 9, 2019

Closing in favour of #5344.

@luabud luabud closed this as completed Oct 9, 2019
@ghost ghost removed the needs PR label Oct 9, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority meta Issue that is tracking an overall project
Projects
None yet
Development

No branches or pull requests

5 participants