autocomplete doesn't work for non-ASC identifiers on Win7, and some cases on Mac

[nobodxbodon]

Steps to cause the bug to occur

1. Below are the sample codes I used to reproduce the issue:

for 名字 in range(1, 10):
    # 有补全（Mac下），输入”名“
    print(名字)

When keying in the parameter of print, typing in the first character should trigger auto-complete, as the ASC identifier works.

Actual & Expected behavior

This 名字 variable triggers auto-complete under Mac:

However a a different name 序号 doesn't work under Mac:

Additionally, neither case works under Windows 7.

Your Jupyter and/or Python environment

Please provide as much info as you readily know

• Jupyter server running: Local | Remote | N/A
• Extension version: 2019.10.44104-xxx
• VS Code version: 1.39.2
• Setting python.jediEnabled: true | false
• Python and/or Anaconda version: 3.7.3 under Mac, 3.6.5 under Win7
• OS: Windows | Mac
• Virtual environment: N/A

Developer Tools Console Output

None.

[rchiodo]

Thanks for the issue.

Does this work inside of the python editor? Or are you only seeing this in notebook cells?

[nobodxbodon]

@rchiodo in the python editor I suppose:

Frankly I've not known of Jupyter Notebooks before, so please excuse me if I opened the issue in the wrong category.

[rchiodo]

Sorry not sure what your answer was. Does the problem also occur in the python editor or does it behave as expected there?

[nobodxbodon]

@rchiodo the problem occurred in python editor, as I only tested there.

[xgdgsc]

Doesn't work for me in linux in neither python editor nor notebook.

[karthiknadig]

@nobodxbodon @xgdgsc Are you using Jedi or Language Server? Please check the settings and let us know if JediEnabled is set.

[nobodxbodon]

@karthiknadig seems not for me:

[xgdgsc]

Works for me on another machine using language server. I think it maybe the other machine using jedi. Thanks.

[karthiknadig]

@nobodxbodon moving this to LS repo. Since it looks like you are using LS and running into this issue.

@xgdgsc If the issue you see is with jedi then please file it on the jedi repo: https://github.com/davidhalter/jedi

[jakebailey]

I'm not sure that this is an LS issue as much as it would be a VS Code issue to do with when they choose to send the completion request in this scenario. For example, I can hit Ctrl-Space to manually trigger a completion request, and we behave as expected.

@xgdgsc If you hit Ctrl+Space after typing the first character, does the expected thing happen?

[MikhailArkhipov]

I wonder what happens with the same character in, say, C# or C++.

[jakebailey]

I know that the input method in the issue isn't the Wubi method (I think this is macOS's pinyin mode), but it may be similar to microsoft/vscode#83428 as the input method replaces written text with another string.

[nobodxbodon]

@MikhailArkhipov TypeScript works under Mac for both cases as below, IIH.
名字：

序号：

@jakebailey I'm using a third-party pinyin input method (Sogou), but I can test with other input method.

[jakebailey]

TS is somewhat special as it ships with VS Code (I think they're able to do things outside the LSP), so there might be a difference there.

[nobodxbodon]

@jakebailey thanks for informing. C++ seems to have the same issue under Mac (序 doesn't get auto-completion):

Extension: ms-vscode.cpptools 0.25.1

[jakebailey]

Thanks for checking.

You may want to respond on microsoft/vscode#83428 or create a new issue on the VS Code repo with your info (and potentially a link here), as this seems to be a VS Code bug involving input methods that do text replacement, rather than something language specific that we can handle on our end.

[jakebailey]

I've linked this thread on their issue for more datapoints, but it's going to have to be a VS Code fix.