You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are two issues to this bug. We should probably be checking for the version of react-native in the package.json, and give a nice error message if they are using a non-supported version of react-native.
The other issue that we need to fix is that .done() in the method Packager.start() line 56 doesn't has a failure handler, so it'll throw an exception if that logic fails. In the case I'm testing the method monkeyPatchOpnForRNPackager fails because version 0.14 of react native doesn't has the opn library where the code expect it. We should make sure we handle that case graciously, and make sure all the .done()s we have in the whole project have a proper way of handle rejected promises.
The text was updated successfully, but these errors were encountered:
This is what we get:
There are two issues to this bug. We should probably be checking for the version of react-native in the package.json, and give a nice error message if they are using a non-supported version of react-native.
The other issue that we need to fix is that .done() in the method Packager.start() line 56 doesn't has a failure handler, so it'll throw an exception if that logic fails. In the case I'm testing the method monkeyPatchOpnForRNPackager fails because version 0.14 of react native doesn't has the opn library where the code expect it. We should make sure we handle that case graciously, and make sure all the .done()s we have in the whole project have a proper way of handle rejected promises.
The text was updated successfully, but these errors were encountered: