Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The extension fails badly if run with a non supported version of React-Native #58

Closed
digeff opened this issue Feb 18, 2016 · 1 comment
Assignees

Comments

@digeff
Copy link
Contributor

digeff commented Feb 18, 2016

This is what we get:
image

There are two issues to this bug. We should probably be checking for the version of react-native in the package.json, and give a nice error message if they are using a non-supported version of react-native.

The other issue that we need to fix is that .done() in the method Packager.start() line 56 doesn't has a failure handler, so it'll throw an exception if that logic fails. In the case I'm testing the method monkeyPatchOpnForRNPackager fails because version 0.14 of react native doesn't has the opn library where the code expect it. We should make sure we handle that case graciously, and make sure all the .done()s we have in the whole project have a proper way of handle rejected promises.

@nisheetjain nisheetjain modified the milestone: Preview Feb 18, 2016
@nisheetjain nisheetjain added known-issues Known issues for extension, most of them are external issues and removed known-issues Known issues for extension, most of them are external issues labels Feb 20, 2016
@digeff
Copy link
Contributor Author

digeff commented Feb 22, 2016

This was solved in: #62

@digeff digeff closed this as completed Feb 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants