Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'cached' consistency to improve file system performance on OS X #1210

Closed
egamma opened this issue Aug 20, 2019 · 0 comments
Closed

Use 'cached' consistency to improve file system performance on OS X #1210

egamma opened this issue Aug 20, 2019 · 0 comments
Assignees
Labels
containers Issue in vscode-remote containers feature-request Request for new features or functionality verified Verification succeeded
Milestone

Comments

@egamma
Copy link
Member

egamma commented Aug 20, 2019

Docker provides different 'consistency' options to improve the file system access performance on non-Linux systems: https://docs.docker.com/docker-for-mac/osxfs-caching/ and https://blog.docker.com/2017/05/user-guided-caching-in-docker-for-mac/

I did a mini benchmark npm install gulp:

Mount Type
type=bind, consistency=consistent 32s
type=bind, consistency=cached 21s
type=bind, consistency=delegated 20s
type=volume 15s
Local fs access 11s

The consistency guarantees of consistency=cached are:

The host’s view of the mount is authoritative. There may be delays before updates made on the host are visible within a container

This aligns well with containers, where most of the work happens inside a container with occasional host access with a tool running outside the container. Also there can be no data loss when the container is killed.

Given the performance improvement the propsoal is to use consistency=cached by default for bind mounts.

In addition, we should expose a setting where the user can tune the consistency for development containers.

@egamma egamma added containers Issue in vscode-remote containers feature-request Request for new features or functionality labels Aug 20, 2019
@chrmarti chrmarti added this to the August 2019 milestone Aug 20, 2019
@egamma egamma added the verified Verification succeeded label Aug 28, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
containers Issue in vscode-remote containers feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants