Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev container iteration when using "Inspect volume" flow ideally would mirror bind mounts #3123

Closed
Chuxel opened this issue Jun 3, 2020 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug containers Issue in vscode-remote containers verified Verification succeeded
Milestone

Comments

@Chuxel
Copy link
Member

Chuxel commented Jun 3, 2020

Testing #3099

Right now I'm working on microsoft/vscode-dev-containers#339 to create a development container for Code - OSS. I plan to switch to using the "open repo" flow now that I can iterate on it.

However, as I started using it, I'm not finding it quite as convenient as the bind mount flow. In this case I do the following:

  1. Open folder in container...
  2. On error, click reopen locally
  3. Make my edits
  4. Reopen in container
  5. Go to 2.

I'd envisioned the workflow for using this inspect feature being like this:

  1. Open repository in container...
  2. On error, click "reopen in recovery container"
  3. Make my edits
  4. Reopen in container
  5. Go to 2.

The "inspect volume" that appears in step 2 didn't quite click immediately as something I'd do to fix a Dockerfile issue. Once I was inspecting, I also had no quick way to get back, I had to use the MRU list to do it. This is different enough that I'll likely have to have a second section on iterating in docs to describe it - and it's not quite as natural. Going back to "Open Repo in Conatiner" would force me to re-enter the URL and would actually create a new container even if I reused the same volume.

As I build things out, I'll end up doing this iteration in rapid succession since there's no "debug" flow for Dockerfiles... it's like classic "run plus debug output" workflows. So, this is a frequent flow.

@Chuxel Chuxel added the containers Issue in vscode-remote containers label Jun 3, 2020
@egamma egamma added this to the June 2020 milestone Jun 4, 2020
@egamma
Copy link
Member

egamma commented Jun 4, 2020

Related #3112, #3111

@egamma egamma modified the milestones: June 2020, May 2020 Jun 7, 2020
@egamma egamma closed this as completed Jun 7, 2020
@chrmarti chrmarti added bug Issue identified by VS Code Team member as probable bug verified Verification succeeded labels Jun 8, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug containers Issue in vscode-remote containers verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants