Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using podman-compose for dockerComposePath fails version check #5553

Closed
Codecasaurus opened this issue Sep 6, 2021 · 5 comments
Closed

Using podman-compose for dockerComposePath fails version check #5553

Codecasaurus opened this issue Sep 6, 2021 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug containers Issue in vscode-remote containers podman Dev Container using Podman

Comments

@Codecasaurus
Copy link

  • VSCode Version: 1.59.1
  • Local OS Version: Fedora 34
  • Remote OS Version: Fedora 34
  • Remote Extension/Connection Type: Docker
  • Logs:
[2021-09-06T14:41:17.788Z] Start: Run: podman version --format {{.Server.APIVersion}}
[2021-09-06T14:41:17.788Z] Remote-Containers 0.191.1 in VS Code 1.59.1 (3866c3553be8b268c8a7f8c0482c0c0177aa8bfa).
[2021-09-06T14:41:17.921Z] Stop (133 ms): Run: podman version --format {{.Server.APIVersion}}
[2021-09-06T14:41:17.921Z] 3.3.1
[2021-09-06T14:41:17.929Z] Start: Run: podman-compose --version
[2021-09-06T14:41:17.992Z] Stop (63 ms): Run: podman-compose --version
[2021-09-06T14:46:22.954Z] Start: Run: podman version --format {{.Server.APIVersion}}
[2021-09-06T14:46:23.086Z] Stop (132 ms): Run: podman version --format {{.Server.APIVersion}}
[2021-09-06T14:46:23.086Z] 3.3.1
[2021-09-06T14:46:23.096Z] Start: Run: podman-compose --version
[2021-09-06T14:46:23.162Z] Stop (66 ms): Run: podman-compose --version
[2021-09-06T14:48:22.988Z] Start: Run: podman version --format {{.Server.APIVersion}}
[2021-09-06T14:48:23.117Z] Stop (129 ms): Run: podman version --format {{.Server.APIVersion}}
[2021-09-06T14:48:23.118Z] 3.3.1
[2021-09-06T14:48:23.125Z] Start: Run: podman-compose --version
[2021-09-06T14:48:23.188Z] Stop (63 ms): Run: podman-compose --version

Steps to Reproduce:

  1. Have podman and podman-compose installed
  2. Modify vscode remote container settings:
"remote.containers.dockerComposePath": "podman-compose",
"remote.containers.dockerPath": "podman",
  1. Open a dev container

Does this issue occur when you try this locally?: Yes
Does this issue occur when you try this locally and all extensions are disabled?: Yes


#3886 added the setting to configure a "docker-compose" path. There is what appears to be a version check shown in the logs for compose, but the syntax is incorrect for podman-compose. podman-compose --version is invalid, and it should be podman-compose version.

Additionally, I'd expect the versioning check (if there actually is a specific release requirement) between docker-compose and podman-compose to be incompatible.

@github-actions github-actions bot added the containers Issue in vscode-remote containers label Sep 6, 2021
@chrmarti chrmarti self-assigned this Sep 8, 2021
@chrmarti chrmarti added the bug Issue identified by VS Code Team member as probable bug label Sep 8, 2021
@muayyad-alsadi
Copy link

muayyad-alsadi commented Jan 13, 2022

any update on this, because it might be working on latest devel branch podman-compose

@chrmarti
Copy link
Contributor

We are using docker-compose version and docker-compose version --short now.

@muayyad-alsadi
Copy link

I mean did this merged commit fixed your problem?

containers/podman-compose#394

@chrmarti chrmarti added the podman Dev Container using Podman label Dec 15, 2022
@smorokin
Copy link

smorokin commented Jan 23, 2023

@muayyad-alsadi Hi, I just tested this with the following combination of tools

$ podman-compose --version
['podman', '--version', '']
using podman version: 4.3.1
podman-composer version  1.0.4
podman --version 
podman version 4.3.1
exit code: 0

$ code --version
1.74.3
97dec172d3256f8ca4bfb2143f3f76b503ca0534
x64

running on debian testing and everything seems to work fine.

The benefit is much faster rebuilds of the container (and I also guess faster builds) since the project is not transfered via socket to docker.

Edit:

  • The 1.0.4 version of podman-compose is required. It is not released yet.
  • There is an issue with the current version of the devcontainer extension and podman-compose. It only works with the 0.234.0 version of the extension.

@chrmarti
Copy link
Contributor

Closing as fixed, thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug containers Issue in vscode-remote containers podman Dev Container using Podman
Projects
None yet
Development

No branches or pull requests

4 participants