Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review/add commands to be surfaced when connected from WSL #5765

Closed
c0g1t8 opened this issue Oct 25, 2021 · 6 comments
Closed

Review/add commands to be surfaced when connected from WSL #5765

c0g1t8 opened this issue Oct 25, 2021 · 6 comments
Assignees
Labels
containers Issue in vscode-remote containers plan-item A plan item
Milestone

Comments

@c0g1t8
Copy link

c0g1t8 commented Oct 25, 2021

  • VSCode Version: 1.61.2
  • Local OS Version: Windows 10 Pro
  • Remote OS Version: Ubuntu 20.04.3
  • Remote Extension/Connection Type: SSH/Docker/WSL2
  • Logs:

Remote-Containers: Try a Sample is not available as a command.

I've already filed an issue in the Visual Studio Code documentation repository - microsoft/vscode-docs#4908

@gregvanl
Copy link

I believe it was renamed to Try a Development Container Sample.

image

@github-actions github-actions bot added the containers Issue in vscode-remote containers label Oct 25, 2021
@gregvanl
Copy link

Documentation updated and confirmed that the command was renamed

@gregvanl
Copy link

Reopening so that @c0g1t8 can add more details about the specific scenario on WSL2.

@gregvanl gregvanl reopened this Oct 25, 2021
@c0g1t8
Copy link
Author

c0g1t8 commented Oct 25, 2021

This is a follow up to my comment - microsoft/vscode-docs#4908 (comment).

Remote-Containers extension does not behave in WSL2 as expected. Remote-Containers: Try a Development Container Sample... is not available when remoting to WSL2. I've been able to confirm this with WSL2(Ubuntu 20.04) on both Windows 10 Pro and Windows Pro 11. The expectation is that the extension should behave the same in WSL2 as in Windows.

I believe the issue lies with the VS Code server running in Linux. That's a guess.🤔

@c0g1t8 c0g1t8 changed the title Remote Containers Try a Sample command is missing Remote Containers Try a Sample command is missing when run from WSL2 Oct 26, 2021
@chrmarti chrmarti self-assigned this Oct 26, 2021
@chrmarti
Copy link
Contributor

Related: #5014

We show only part of the commands when connected with Remote-WSL. This was to avoid overloading the UI with commands. As Remote-WSL (and to a degree Remote-SSH) more and more becomes a starting point for Remote-Containers connections, we can make some of these commands also available while already connected with Remote-WSL.

@chrmarti chrmarti added the bug Issue identified by VS Code Team member as probable bug label Oct 26, 2021
@chrmarti chrmarti added this to the November 2021 milestone Oct 26, 2021
@chrmarti
Copy link
Contributor

Updated with changes for #2994.

@chrmarti chrmarti added plan-item A plan item and removed bug Issue identified by VS Code Team member as probable bug labels Nov 29, 2021
@chrmarti chrmarti changed the title Remote Containers Try a Sample command is missing when run from WSL2 Review/add commands to be surfaced when connected from WSL Nov 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
containers Issue in vscode-remote containers plan-item A plan item
Projects
None yet
Development

No branches or pull requests

3 participants