Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional features not applied #7411

Closed
joaomoreno opened this issue Oct 25, 2022 · 6 comments
Closed

Additional features not applied #7411

joaomoreno opened this issue Oct 25, 2022 · 6 comments
Assignees
@chrmarti
Labels
bug Issue identified by VS Code Team member as probable bug containers Issue in vscode-remote containers
Milestone
October 2022

Comments

@joaomoreno
Copy link
Member

Testing #7403

Following the test plan item flow, I additionally pick fish as an additional feature to add to my devcontainer...

image

But it doesn't seem like that did anything:

image
@chrmarti chrmarti added bug Issue identified by VS Code Team member as probable bug containers Issue in vscode-remote containers labels Oct 25, 2022
@chrmarti chrmarti added this to the October 2022 milestone Oct 25, 2022
@joyceerhl joyceerhl added the verified Verification succeeded label Oct 27, 2022
@joyceerhl joyceerhl mentioned this issue Oct 27, 2022
Open
@joyceerhl
Copy link

Still repros, I think this is not yet ready for verification since there hasn't been a new release since https://github.com/microsoft/vscode-remote-containers/pull/313

@joyceerhl joyceerhl added unreleased and removed verified Verification succeeded labels Oct 27, 2022
@rzhao271 rzhao271 added verified Verification succeeded and removed unreleased labels Oct 28, 2022
@rzhao271
Copy link

rzhao271 commented Oct 28, 2022 •
edited

Not sure if the feature is still unavailable.
I wasn't prompted to select additional features. Instead, the dev container just tried to build, and failed.
Screenshot showing ls command failed when trying to build the container

Edit: After clicking OK, I got the option to select the container type and additional features. Fish still wasn't applied after the container finished building.

@rzhao271 rzhao271 removed the verified Verification succeeded label Oct 28, 2022
@joyceerhl joyceerhl added the verified Verification succeeded label Nov 1, 2022
@joyceerhl
Copy link

Still repros for me in v0.262.1

@joyceerhl joyceerhl added verification-found Issue verification failed and removed verified Verification succeeded labels Nov 1, 2022
@joyceerhl joyceerhl reopened this Nov 1, 2022
@chrmarti
Copy link
Contributor

chrmarti commented Nov 2, 2022

@joyceerhl Could you provide steps to reproduce?

@chrmarti chrmarti added info-needed Issue requires more information from poster and removed verification-found Issue verification failed labels Nov 2, 2022
@chrmarti chrmarti modified the milestones: October 2022, November 2022 Nov 2, 2022
@joyceerhl
Copy link

I followed the flow that Joao described with the latest Containers extension and created an Alpine container with the fish feature. After the container was created, fish was not on the path.

@chrmarti
Copy link
Contributor

Thanks, tracking as devcontainers/spec#58. Closing as fixing the UI issue.

@chrmarti chrmarti removed the info-needed Issue requires more information from poster label Nov 28, 2022
@chrmarti chrmarti modified the milestones: November 2022, October 2022 Nov 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
bug Issue identified by VS Code Team member as probable bug containers Issue in vscode-remote containers
Projects
None yet
Milestone
October 2022
Development

No branches or pull requests
4 participants
@joaomoreno @rzhao271 @chrmarti @joyceerhl